Summary: | v2: WebKit::XPCServiceEventHandler block should call exit() on the main thread | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, ggaren, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 216594 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2020-10-15 11:42:30 PDT
Created attachment 411471 [details]
Patch v1
Yes, during exit libdispatch somewhat randomly picks a new thread to be the "main queue" thread. I have seen many cases where this behavior confused someone and no cases where it helped someone. Oh well. To clarify, it's not that the *current* thread became the main queue thread; that would have caused a deadlock. Instead, some *other* thread became the main queue thread, and we called exit() on that thread. Comment on attachment 411471 [details]
Patch v1
r=me
Committed r268570: <https://trac.webkit.org/changeset/268570> (In reply to David Kilzer (:ddkilzer) from comment #5) > Committed r268570: <https://trac.webkit.org/changeset/268570> Just modified the commit log message to reflect Geoff's comments in Comment #3. |