Bug 21777

Summary:	pretty patch format should turn paths into links
Product:	WebKit	Reporter:	Eric Seidel (no email) <eric>
Component:	WebKit Website	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	aroben
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Mac
OS:	OS X 10.5

Description Eric Seidel (no email) 2008-10-21 14:44:31 PDT

pretty patch format should turn paths into links

https://bugs.webkit.org/attachment.cgi?id=24528&action=prettypatch

wtf/Platform.h should be a link to:
http://trac.webkit.org/browser/trunk/JavaScriptCore/wtf/Platform.h

Rietveld has this functionality and I miss it when I review patches @ bugs.webkit.org instead of codereviews.chromium.org

Comment 1 Adam Roben (:aroben) 2008-10-21 14:51:50 PDT

We do turn paths into links when the paths are relative to the top level of the WebKit repository. Here's an example:

https://bugs.webkit.org/attachment.cgi?id=24349&action=prettypatch

How does Reitveld figure out where to link paths that are not relative to the top level of the repository?

Comment 2 Eric Seidel (no email) 2008-10-21 16:34:22 PDT

There is some special upload script, I'm not entirely sure.  Evan or John would know... if I could only figure out how to CC them

Comment 3 Evan Martin 2008-10-21 16:37:36 PDT

The uploader uploads enough information into Rietveld that it can reconstruct the full before/after versions of the file, so it doesn't need to refer to the repo.

(Another alternative, for what it's worth, is to by convention request patches to be relative to the top-level directory.  The links would then be broken for patches that didn't follow that convention.)

Comment 4 Evan Martin 2009-12-20 03:34:54 PST

BTW, Rietveld *originally* did the strategy of "upload patch + base URL for files referenced in the patch", but that is SVN-specific (there's no good way to grab an arbitrary file from a remote git repo), so they migrated away from it.