Summary: | REGRESSION: ASSERTION FAILED: !needsLayout() on webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html (flaky) | ||
---|---|---|---|
Product: | WebKit | Reporter: | Karl Rackler <rackler> |
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | ap, bfulgham, cdumez, dino, jdarpinian, kbr, kkinnunen, ryanhaddad, sam, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=219219 | ||
Bug Depends on: | 217198, 217813 | ||
Bug Blocks: |
Description
Karl Rackler
2020-10-15 09:53:04 PDT
I have marked this test as flaky crash while this issue is investigated. https://trac.webkit.org/changeset/268527/webkit r266662 is surprising as a regression point, but if true, that could be a serious problem. This one has a complicated history. I could reproduce starting with r266364, where WEBGL_compressed_texture_s3tc_srgb extension was implemented. This assertion seems unlikely to have anything to do with S3TC or WebGL, it's probably just because the test started to have a long output after the feature got implemented. It's about 15 pages on my screen. Then this was completely fixed by r266645, Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess. It became easily reproducible again after r266710, where the above was reverted. Then r266645 was re-landed in r266797, but the issue was not completely fixed this time. It's still reproducible, but only about once in a 1000 iterations. So either the new DisplayLink patch is not as effective as the original one, or something happened between r266710 and r266797 that created a new reason for the test to assert. This is the only test for a feature, so it's pretty important. *** Bug 219219 has been marked as a duplicate of this bug. *** There have been several reports of this assertion failure - linked to and duplicated all related bugs into this one. How can we make progress on it? It sounds like any test which produces a lot of output might trigger this. Could anyone with experience in WebKit's layout code explain the assertion failure and what potential root causes might be? This assertion is usually about whether AppKit calls -viewWillDraw on the WebView/WebHTMLView when we expect. Skipped the two affected tests on macOS WK1 debug with r271461. *** This bug has been marked as a duplicate of bug 229580 *** |