Bug 217701 – [Flatpak SDK] file descriptor leak when running inspector tests

• Component: Tools / Tests
• Status: NEW

[Philippe Normand]

This is a regression in version 0.3 of the SDK. 0.2 is fine. Probably something to investigate in at-spi.

Thread 1 (Thread 0x7f5b5ed08a00 (LWP 672)):
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007f5b5fc87855 in __GI_abort () at abort.c:79
#2  0x00007f5b5ed6c992 in _dbus_abort () at ../../dbus/dbus-sysdeps.c:93
#3  0x00007f5b5ed90170 in _dbus_warn_check_failed (format=format@entry=0x7f5b5eda0da8 "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at ../../dbus/dbus-internals.c:281
#4  0x00007f5b5ed908de in _dbus_warn_return_if_fail (function=function@entry=0x7f5b5ed9fa60 <__func__.62> "dbus_message_new_method_call", assertion=assertion@entry=0x7f5b5ed9e708 "destination == NULL || _dbus_check_is_valid_bus_name (destination)", file=file@entry=0x7f5b5ed9e31a "../../dbus/dbus-message.c", line=line@entry=1364) at ../../dbus/dbus-internals.c:936
#5  0x00007f5b5ed7f402 in dbus_message_new_method_call (destination=destination@entry=0x13c4360 "", path=0x13c4362 "1\001", iface=iface@entry=0x7f5b5f1e6cd1 "org.a11y.atspi.Socket", method=method@entry=0x7f5b5f1e6dde "Embedded") at ../../dbus/dbus-message.c:1364
#6  0x00007f5b5f1ccc31 in socket_embed_hook (socket=0x1392e50 [WebKitWebViewAccessible], plug_id=<optimized out>) at ../atk-adaptor/bridge.c:625
#7  0x00007f5b67e1b5b5 in WebKit::WebPageProxy::bindAccessibilityTree(WTF::String const&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#8  0x00007f5b679b590e in WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#9  0x00007f5b67bf37c5 in IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#10 0x00007f5b67cd3e6a in non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#11 0x00007f5b67bed4b9 in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder, std::default_delete<IPC::Decoder> >) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#12 0x00007f5b67bec9df in IPC::Connection::dispatchIncomingMessages() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#13 0x00007f5b6569c466 in WTF::RunLoop::performWork() () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#14 0x00007f5b656f73d6 in WTF::RunLoop::RunLoop()::$_1::__invoke(void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#15 0x00007f5b656f68ca in WTF::RunLoop::$_0::__invoke(_GSource*, int (*)(void*), void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#16 0x00007f5b6b3e004f in g_main_dispatch (context=0xc49c80) at ../glib/gmain.c:3325
#17 g_main_context_dispatch (context=0xc49c80) at ../glib/gmain.c:4016
#18 0x00007f5b6b3e03f8 in g_main_context_iterate (context=0xc49c80, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4092
#19 0x00007f5b6b3e0713 in g_main_loop_run (loop=0x1199ad0) at ../glib/gmain.c:4290
#20 0x00007f5b656f6e6b in WTF::RunLoop::run() () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#21 0x000000000047370a in WTR::TestController::platformRunUntil(bool&, WTF::Seconds) ()
#22 0x0000000000445ef6 in WTR::TestController::resetStateToConsistentValues(WTR::TestOptions const&, WTR::TestController::ResetStage) ()
#23 0x000000000044547b in WTR::TestController::ensureViewSupportsOptionsForTest(WTR::TestInvocation const&) ()
#24 0x00000000004479f9 in WTR::TestController::configureViewForTest(WTR::TestInvocation const&) ()
#25 0x000000000045e74b in WTR::TestInvocation::invoke() ()
#26 0x0000000000448432 in WTR::TestController::runTest(char const*) ()
#27 0x0000000000448681 in WTR::TestController::runTestingServerLoop() ()
#28 0x000000000044191c in WTR::TestController::TestController(int, char const**) ()
#29 0x0000000000474366 in main ()
 
STDERR: dbus[672]: arguments to dbus_message_new_method_call() were incorrect, assertion "destination == NULL || _dbus_check_is_valid_bus_name (destination)" failed in file ../../dbus/dbus-message.c line 1364.
STDERR: This is normally a bug in some application using the D-Bus library.
STDERR:
STDERR:   D-Bus not built with -rdynamic so unable to print a backtrace

[Philippe Normand]

Can't reproduce anymore :( 

with `run-webkit-tests --gtk --no-retry-failures  inspector/` I had a bunch of warnings like:

** (process:353020): WARNING **: 09:11:44.938: Failed to connect to bus: Unable to create socket: Too many open files

But it's not the case no more /o\

[Lauro Moura]

I managed to reproduce rather consistently here (Ubuntu 20.04 / Ryzen 5 3600 - 12 threads) with `inspector/` and `--iterations=2 --child-processes=36`

It starts emitting these messages around late 400's test cases.

Also appeared with `--child-processes=36 --repeat-each=2` in the late 300's.