Bug 217682

Summary:

Web Inspector: REGRESSION(r267148): new Big Sur styles are not used

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Description Devin Rousso 2020-10-13 16:46:06 PDT

# STEPS TO REPRODUCE
1. inspect any page
2. detach/undock Web Inspector

# EXPECTED
Title bar is white and the close/minimize/fullscreen buttons are vertically centered.

# ACTUAL
Title bar uses macOS Catalina styling.

Comment 1 Devin Rousso 2020-10-13 16:46:21 PDT

<rdar://problem/70269030>

Comment 2 Devin Rousso 2020-10-13 16:51:29 PDT

Created attachment 411279 [details]
Patch

I'm not sure what the best/right way to go about doing this is, but this is my initial thought of how to do it

Comment 3 BJ Burg 2020-10-13 17:24:50 PDT

Comment on attachment 411279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411279&action=review

The approach is sane, and I couldn't find any mistakes.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:392
> +String InspectorFrontendHost::platformVersionName() const

Reminder to future self, we need to update this every year. =)

> Source/WebInspectorUI/UserInterface/Views/Popover.js:238
> +        var titleBarOffset = WI.undockedTitleAreaHeight();

Yikes, this is definitely an improvement in clarity.

Comment 4 Devin Rousso 2020-10-13 20:04:58 PDT

Created attachment 411296 [details]
Patch

apparently `classList.add("")` throws an error :|

... and here I thought I'd seen it all

Comment 5 EWS 2020-10-14 10:50:59 PDT

Committed r268473: <https://trac.webkit.org/changeset/268473>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411296 [details].