Bug 217682

Summary: Web Inspector: REGRESSION(r267148): new Big Sur styles are not used
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2020-10-13 16:46:06 PDT
# STEPS TO REPRODUCE 1. inspect any page 2. detach/undock Web Inspector # EXPECTED Title bar is white and the close/minimize/fullscreen buttons are vertically centered. # ACTUAL Title bar uses macOS Catalina styling.
Attachments
Patch (11.44 KB, patch)
2020-10-13 16:51 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (11.15 KB, patch)
2020-10-13 20:04 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-10-13 16:46:21 PDT
<rdar://problem/70269030>
Devin Rousso
Comment 2 2020-10-13 16:51:29 PDT
Created attachment 411279 [details] Patch I'm not sure what the best/right way to go about doing this is, but this is my initial thought of how to do it
Blaze Burg
Comment 3 2020-10-13 17:24:50 PDT
Comment on attachment 411279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411279&action=review The approach is sane, and I couldn't find any mistakes. > Source/WebCore/inspector/InspectorFrontendHost.cpp:392 > +String InspectorFrontendHost::platformVersionName() const Reminder to future self, we need to update this every year. =) > Source/WebInspectorUI/UserInterface/Views/Popover.js:238 > + var titleBarOffset = WI.undockedTitleAreaHeight(); Yikes, this is definitely an improvement in clarity.
Devin Rousso
Comment 4 2020-10-13 20:04:58 PDT
Created attachment 411296 [details] Patch apparently `classList.add("")` throws an error :| ... and here I thought I'd seen it all
EWS
Comment 5 2020-10-14 10:50:59 PDT
Committed r268473: <https://trac.webkit.org/changeset/268473> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411296 [details].
Note You need to log in before you can comment on or make changes to this bug.