Bug 217649

Summary: Remove leftover MACOSX_DEPLOYMENT_TARGET_macosx support
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, cdumez, darin, ddkilzer, dino, eric.carlson, ews-watchlist, graouts, hi, jbedard, keith_miller, kondapallykalyan, mark.lam, msaboff, rniwa, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-10-12 20:34:42 PDT
Bug 42796 introduced MACOSX_DEPLOYMENT_TARGET_<PLATFORM> as "support for compiling WebKit against iOS SDKs". Support for the iOS part of this feature was later removed in several changes, including Bug 139212, Bug 139463 and Bug 144762. However, vestiges have remained for five or six years in the form of MACOSX_DEPLOYMENT_TARGET_macosx. The inclusion of the platform in MACOSX_DEPLOYMENT_TARGET is no longer needed and can be removed. This changes brings most projects in conformance with other projects that don't support including the platform in MACOSX_DEPLOYMENT_TARGET, including WebEditingTester, gtest, WebKitTestRunner, MiniBrowser, and TestWebKitAPI. Along the way, remove a couple of left-over references to macOS 10.16, and a couple of places where [sdk=macosx*] was still being used. With this change, initialization of MACOSX_DEPLOYMENT_TARGET should be consistent across all projects, with two exceptions: WebKitLauncher (which hardcodes it to 10.12) and libwebrtc's copy of googletest (which hardcodes it to 10.4). The reasons for these hard-coded values is not apparent, so leave them be.
Attachments
Patch (43.99 KB, patch)
2020-10-12 20:44 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-12 20:34:54 PDT
<rdar://problem/70236877>
Keith Rollin
Comment 2 2020-10-12 20:44:20 PDT
Created attachment 411193 [details] Patch
EWS Watchlist
Comment 3 2020-10-12 20:45:20 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
EWS
Comment 4 2020-10-13 14:25:52 PDT
Committed r268420: <https://trac.webkit.org/changeset/268420> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411193 [details].
Alexey Proskuryakov
Comment 5 2020-10-14 14:17:03 PDT
Comment on attachment 411193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411193&action=review > Source/JavaScriptCore/ChangeLog:26 > + consistent across all projects, with two exceptions: WebKitLauncher I didn't realize that we still had it the tree! Bug 217729 Remove WebKitLauncher.
Note You need to log in before you can comment on or make changes to this bug.