| Summary: | [WebIDL] convertRecord() should handle duplicate keys for USVString records | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||
| Component: | Bindings | Assignee: | Alexey Shvayka <ashvayka> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Trivial | CC: | achristensen, cdumez, clopez, ews-watchlist, sam, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: | https://github.com/web-platform-tests/wpt/pull/26126 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Shvayka
2020-10-12 09:34:11 PDT
Created attachment 411134 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 411134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411134&action=review > LayoutTests/imported/w3c/ChangeLog:9 > + * web-platform-tests/url/urlsearchparams-constructor.any-expected.txt: > + * web-platform-tests/url/urlsearchparams-constructor.any.js: Usually we don't modify the imported tests directly, or if we do, try to get that change integrated upstream as well. Is this something you plan to do with this change? (In reply to Sam Weinig from comment #3) Thank you for review, Sam. > Usually we don't modify the imported tests directly, or if we do, try to get > that change integrated upstream as well. Is this something you plan to do > with this change? I've got acquainted with WPT export process and make sure that tests are merged into upstream before landing a patch. (In reply to Alexey Shvayka from comment #4) > (In reply to Sam Weinig from comment #3) > > Thank you for review, Sam. > > > Usually we don't modify the imported tests directly, or if we do, try to get > > that change integrated upstream as well. Is this something you plan to do > > with this change? > > I've got acquainted with WPT export process and make sure that tests are > merged into upstream before landing a patch. Great. Thanks. Created attachment 411786 [details]
Patch
Adjust .worker subtest expectations.
Committed r268709: <https://trac.webkit.org/changeset/268709> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411786 [details]. Comment on attachment 411786 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411786&action=review > Source/WebCore/bindings/js/JSDOMConvertRecord.h:134 > + auto index = result.findMatching([&](auto& entry) { return entry.key == typedKey; }); This is an O(n^2) algorithm. See https://bugs.webkit.org/show_bug.cgi?id=218062 |