Bug 217593

Summary: Build failures and warning under Source/WebCore/layout/integration/
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebCore Misc.Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2020-10-11 17:04:27 PDT
Multiple issues here:

In file included from ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.h:28,
                 from ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:27,
                 from DerivedSources/WebCore/unified-sources/UnifiedSource-207b877e-5.cpp:6:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:67:5: error: ‘RunIteratorLegacyPath’ does not name a type; did you mean ‘LineIteratorLegacyPath’?
   67 |     RunIteratorLegacyPath firstRun() const
      |     ^~~~~~~~~~~~~~~~~~~~~
      |     LineIteratorLegacyPath
../../Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:72:5: error: ‘RunIteratorLegacyPath’ does not name a type; did you mean ‘LineIteratorLegacyPath’?
   72 |     RunIteratorLegacyPath lastRun() const
      |     ^~~~~~~~~~~~~~~~~~~~~
      |     LineIteratorLegacyPath
../../Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:77:5: error: ‘RunIteratorLegacyPath’ does not name a type; did you mean ‘LineIteratorLegacyPath’?
   77 |     RunIteratorLegacyPath logicalStartRunWithNode() const
      |     ^~~~~~~~~~~~~~~~~~~~~
      |     LineIteratorLegacyPath
../../Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:84:5: error: ‘RunIteratorLegacyPath’ does not name a type; did you mean ‘LineIteratorLegacyPath’?
   84 |     RunIteratorLegacyPath logicalEndRunWithNode() const
      |     ^~~~~~~~~~~~~~~~~~~~~
      |     LineIteratorLegacyPath
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-207b877e-5.cpp:6:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:82:42: error: return type ‘class WebCore::LayoutIntegration::LineRunIterator’ is incomplete
   82 | LineRunIterator LineIterator::firstRun() const
      |                                          ^~~~~
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘void WebCore::LayoutIntegration::LineIterator::firstRun() const’:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:84:66: error: ‘RunIterator’ does not name a type; did you mean ‘LineIterator’?
   84 |     return WTF::switchOn(m_line.m_pathVariant, [](auto& path) -> RunIterator {
      |                                                                  ^~~~~~~~~~~
      |                                                                  LineIterator
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: At global scope:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:89:41: error: return type ‘class WebCore::LayoutIntegration::LineRunIterator’ is incomplete
   89 | LineRunIterator LineIterator::lastRun() const
      |                                         ^~~~~
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘void WebCore::LayoutIntegration::LineIterator::lastRun() const’:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:91:66: error: ‘RunIterator’ does not name a type; did you mean ‘LineIterator’?
   91 |     return WTF::switchOn(m_line.m_pathVariant, [](auto& path) -> RunIterator {
      |                                                                  ^~~~~~~~~~~
      |                                                                  LineIterator
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: At global scope:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:96:57: error: return type ‘class WebCore::LayoutIntegration::LineRunIterator’ is incomplete
   96 | LineRunIterator LineIterator::logicalStartRunWithNode() const
      |                                                         ^~~~~
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘void WebCore::LayoutIntegration::LineIterator::logicalStartRunWithNode() const’:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:98:66: error: ‘RunIterator’ does not name a type; did you mean ‘LineIterator’?
   98 |     return WTF::switchOn(m_line.m_pathVariant, [](auto& path) -> RunIterator {
      |                                                                  ^~~~~~~~~~~
      |                                                                  LineIterator
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: At global scope:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:103:55: error: return type ‘class WebCore::LayoutIntegration::LineRunIterator’ is incomplete
  103 | LineRunIterator LineIterator::logicalEndRunWithNode() const
      |                                                       ^~~~~
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘void WebCore::LayoutIntegration::LineIterator::logicalEndRunWithNode() const’:
../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:105:66: error: ‘RunIterator’ does not name a type; did you mean ‘LineIterator’?
  105 |     return WTF::switchOn(m_line.m_pathVariant, [](auto& path) -> RunIterator {
      |                                                                  ^~~~~~~~~~~
      |                                                                  LineIterator
[2657/5201] Building CXX object Source/WebCore/CMakeFiles...es/WebCore/unified-sources/UnifiedSource-207b877e-6.cpp.o
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-207b877e-6.cpp:1:
../../Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp:163:31: warning: ‘const WebCore::RenderBlockFlow* WebCore::LayoutIntegration::lineLayoutSystemFlowForRenderer(const WebCore::RenderObject&)’ defined but not used [-Wunused-function]
  163 | static const RenderBlockFlow* lineLayoutSystemFlowForRenderer(const RenderObject& renderer)
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 1 Michael Catanzaro 2020-10-11 17:07:53 PDT
Created attachment 411080 [details]
Patch
Comment 2 zalan 2020-10-11 17:10:08 PDT
thanks!
Comment 3 EWS 2020-10-11 17:39:27 PDT
Committed r268329: <https://trac.webkit.org/changeset/268329>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411080 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-11 17:40:17 PDT
<rdar://problem/70188773>