Bug 217590

Summary: -Wreorder in MediaPlayerPrivateRemote.cpp
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: MediaAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, mcatanzaro, philipj, sergio, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2020-10-11 15:41:36 PDT
-Wreorder indicates the constructor's initializer list is misleading: [2116/2435] Building CXX object Source/WebKit/CMakeFiles/...ces/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp.o In file included from ../../Source/WebKit/WebProcess/GPU/media/AudioTrackPrivateRemote.cpp:32, from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp:7: ../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h: In constructor ‘WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(WebCore::MediaPlayer*, WebCore::MediaPlayerEnums::MediaEngineIdentifier, WebCore::MediaPlayerIdentifier, WebKit::RemoteMediaPlayerManager&)’: ../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:362:27: warning: ‘WebKit::MediaPlayerPrivateRemote::m_player’ will be initialized after [-Wreorder] 362 | WebCore::MediaPlayer* m_player { nullptr }; | ^~~~~~~~ ../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:159:23: warning: ‘WTF::Ref<const WTF::Logger, WTF::DumbPtrTraits<const WTF::Logger> > WebKit::MediaPlayerPrivateRemote::m_logger’ [-Wreorder] 159 | Ref<const Logger> m_logger; | ^~~~~~~~ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp:8: ../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:94:1: warning: when initialized here [-Wreorder] 94 | MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(MediaPlayer* player, MediaPlayerEnums::MediaEngineIdentifier engineIdentifier, MediaPlayerIdentifier playerIdentifier, RemoteMediaPlayerManager& manager) | ^~~~~~~~~~~~~~~~~~~~~~~~
Attachments
Patch (2.02 KB, patch)
2020-10-11 15:49 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-10-11 15:49:04 PDT
Created attachment 411074 [details] Patch
EWS
Comment 2 2020-10-11 17:16:57 PDT
Committed r268328: <https://trac.webkit.org/changeset/268328> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411074 [details].
Radar WebKit Bug Importer
Comment 3 2020-10-11 17:17:16 PDT
<rdar://problem/70188351>
Note You need to log in before you can comment on or make changes to this bug.