Summary: | [ macOS ] webaudio/OfflineAudioContext/onstatechange.html is a flaky failure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hector Lopez <hector_i_lopez> | ||||||
Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Hector Lopez
2020-10-09 17:16:47 PDT
Test expectation while investigated: https://trac.webkit.org/changeset/268303/webkit Created attachment 412960 [details]
Patch
Comment on attachment 412960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412960&action=review > Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:105 > + callOnMainThread([this, result, currentSampleFrame = m_currentSampleFrame, protectedThis = WTFMove(protectedThis)]() mutable { > + context().postTask([this, protectedThis = WTFMove(protectedThis), result, currentSampleFrame]() mutable { Doesn’t seem like we need callOnMainThread if calling postTask. It already does callOnMainThread. Oops, didn’t mean to change this to darin/review? Don’t know why bugs.webkit.org does that. (In reply to Darin Adler from comment #4) > Comment on attachment 412960 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412960&action=review > > > Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:105 > > + callOnMainThread([this, result, currentSampleFrame = m_currentSampleFrame, protectedThis = WTFMove(protectedThis)]() mutable { > > + context().postTask([this, protectedThis = WTFMove(protectedThis), result, currentSampleFrame]() mutable { > > Doesn’t seem like we need callOnMainThread if calling postTask. It already > does callOnMainThread. I think you are looking at the wrong postTask? void BaseAudioContext::postTask(WTF::Function<void()>&& task) { ASSERT(isMainThread()); if (m_isStopScheduled) return; queueTaskKeepingObjectAlive(*this, TaskSource::MediaElement, WTFMove(task)); } OK. Alex said review+. Alex, want to do it again so bugs.webkit.org has the record? Created attachment 412961 [details]
Patch
Committed r269271: <https://trac.webkit.org/changeset/269271> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412961 [details]. |