Bug 217528

Summary: [Media in GPU Process] Enable audio routing arbitration on Mac
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Peng Liu
Reported 2020-10-09 12:58:22 PDT
[Media in GPU Process] Enable audio routing arbitration on Mac
Attachments
Patch (3.44 KB, patch)
2020-10-09 13:08 PDT, Peng Liu 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (3.53 KB, patch)
2020-10-09 14:12 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2020-10-09 13:08:09 PDT
Created attachment 410965 [details] Patch
Eric Carlson
Comment 2 2020-10-09 13:58:21 PDT
Comment on attachment 410965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410965&action=review > Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp:78 > +#elif PLATFORM(MAC) > + AudioSession::setCategory(type, policy); > +#else Please add a FIXME here and reference the bug that will move AudioSessionRoutingArbitratorProxy to the GPU process.
Peng Liu
Comment 3 2020-10-09 14:12:44 PDT
Created attachment 410973 [details] Patch for landing
Peng Liu
Comment 4 2020-10-09 14:14:08 PDT
Comment on attachment 410965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410965&action=review >> Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp:78 >> +#else > > Please add a FIXME here and reference the bug that will move AudioSessionRoutingArbitratorProxy to the GPU process. Done! Filed webkit.org/b/217535 to track that. Thanks!
EWS
Comment 5 2020-10-09 15:15:11 PDT
Committed r268292: <https://trac.webkit.org/changeset/268292> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410973 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-09 15:16:15 PDT
<rdar://problem/70155527>
Note You need to log in before you can comment on or make changes to this bug.