Bug 217439

Summary: [GPU Process] Implement VideoPlaybackMetrics
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Severity: Normal CC: annulen, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch for landing
Patch for landing none

Description Eric Carlson 2020-10-07 12:39:00 PDT
Implement VideoPlaybackMetrics in the GPU Process
Comment 1 Eric Carlson 2020-10-07 12:39:17 PDT
Comment 2 Eric Carlson 2020-10-07 14:33:48 PDT
Created attachment 410780 [details]
Comment 3 Jer Noble 2020-10-07 15:11:59 PDT
Comment on attachment 410780 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=410780&action=review

r=me with nit

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h:301
> +    bool m_setShouldUpdatePlaybackMetrics { false };

Nit: this should probably just be `m_shouldUpdatePlaybackMetrics`.
Comment 4 Eric Carlson 2020-10-07 15:31:29 PDT
Created attachment 410792 [details]
Patch for landing
Comment 5 EWS 2020-10-16 11:10:26 PDT
Tools/Scripts/svn-apply failed to apply attachment 410792 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Eric Carlson 2020-10-16 12:15:36 PDT
Created attachment 411603 [details]
Patch for landing
Comment 7 EWS 2020-10-16 13:10:04 PDT
Committed r268608: <https://trac.webkit.org/changeset/268608>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411603 [details].