Bug 217439

Summary: [GPU Process] Implement VideoPlaybackMetrics
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Eric Carlson
Reported 2020-10-07 12:39:00 PDT
Implement VideoPlaybackMetrics in the GPU Process
Attachments
Patch (24.42 KB, patch)
2020-10-07 14:33 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.40 KB, patch)
2020-10-07 15:31 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.97 KB, patch)
2020-10-16 12:15 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2020-10-07 12:39:17 PDT
<rdar://problem/60179370>
Eric Carlson
Comment 2 2020-10-07 14:33:48 PDT
Created attachment 410780 [details] Patch
Jer Noble
Comment 3 2020-10-07 15:11:59 PDT
Comment on attachment 410780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410780&action=review r=me with nit > Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h:301 > + bool m_setShouldUpdatePlaybackMetrics { false }; Nit: this should probably just be `m_shouldUpdatePlaybackMetrics`.
Eric Carlson
Comment 4 2020-10-07 15:31:29 PDT
Created attachment 410792 [details] Patch for landing
EWS
Comment 5 2020-10-16 11:10:26 PDT
Tools/Scripts/svn-apply failed to apply attachment 410792 [details] to trunk. Please resolve the conflicts and upload a new patch.
Eric Carlson
Comment 6 2020-10-16 12:15:36 PDT
Created attachment 411603 [details] Patch for landing
EWS
Comment 7 2020-10-16 13:10:04 PDT
Committed r268608: <https://trac.webkit.org/changeset/268608> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411603 [details].
Note You need to log in before you can comment on or make changes to this bug.