Bug 217422

Summary: Replace unqualified use of PlatformDisplayID in WebViewImpl
Product: WebKit Reporter: Saagar Jha <saagar>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Saagar Jha
Reported 2020-10-06 20:33:02 PDT
Qualify PlatformDisplayID with WebCore:: in WebViewImpl
Attachments
Patch (2.39 KB, patch)
2020-10-06 20:43 PDT, Saagar Jha 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2020-10-07 11:33 PDT, Saagar Jha 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saagar Jha
Comment 1 2020-10-06 20:43:40 PDT
Created attachment 410731 [details] Patch
Darin Adler
Comment 2 2020-10-06 21:45:03 PDT
Comment on attachment 410731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410731&action=review > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2201 > + WebCore::PlatformDisplayID displayID = WebCore::displayID(window.screen); I suggest we use auto here instead.
Saagar Jha
Comment 3 2020-10-07 11:33:21 PDT
Created attachment 410764 [details] Patch
EWS
Comment 4 2020-10-08 00:57:38 PDT
Committed r268175: <https://trac.webkit.org/changeset/268175> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410764 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-08 00:58:16 PDT
<rdar://problem/70083747>
Note You need to log in before you can comment on or make changes to this bug.