Bug 21738 – [Gtk] use AC_DEFINE for defines and cleanup configure.ac and gnumakefile.ams

• Component: WebKitGTK
• Status: RESOLVED INVALID

[Jan Alonzo]

1. Move defines out of the makefiles and into configure.ac. This should be fine
   now that DRT (at least in Gtk) includes the proper config.h already.

2. Also make configure output quieter by not announcing if we're checking for
   something: options enabled should already be in the configure
   result anyway, and besides I don't think anyone reads those things. And it  
   speeds up configure a bit.
 
3. Plus since most options are enabled by default, switch the option string
   to use --disable instead. I also removed the "default=yes/no" in help string 
   as --disable already suggests that *this* option is already enabled by 
   default.

[Jan Alonzo]

Created attachment 24499 [details]
move defines in AC_DEFINE, cleanup option strings, make configure quieter

Patch to address the points I raised in the bug description

[Jan Alonzo]

Just a note on this.

18:02 < alp> janm: found some sources that still don't use config.h: DerivedSources/webkitmarshal.cpp, gtk2drawing.c, DerivedSources/UserAgentStyleSheetsData.cpp

We need to check for these first before landing the patch if ever.

[Holger Freyther]

Comment on attachment 24499 [details]
move defines in AC_DEFINE, cleanup option strings, make configure quieter


> +if test "$enable_svg_filters" = "yes"; then
> +   AC_DEFINE([ENABLE_SVG_FILTERS],[0],[Define to enable SVG filters])
> +fi

Why define it to 0?

Besides that. I can see how making things more silent can be useful but what happens in the error situation? E.g. it is not said it is searching for jpeg, I don't have it installed, I just get the failure message without actually seeing what was searched for? If that is the case we should do it like many of other autotools consumers.

[Jan Alonzo]

(In reply to comment #3)
> (From update of attachment 24499 [details] [edit])
> 
> > +if test "$enable_svg_filters" = "yes"; then
> > +   AC_DEFINE([ENABLE_SVG_FILTERS],[0],[Define to enable SVG filters])
> > +fi
> 
> Why define it to 0?

Yup it's wrong. Definitely not the way to turn off svg filters by default.

> 
> Besides that. I can see how making things more silent can be useful but what
> happens in the error situation? E.g. it is not said it is searching for jpeg, I
> don't have it installed, I just get the failure message without actually seeing
> what was searched for? If that is the case we should do it like many of other
> autotools consumers.

Yup. I'm planning to update this patch with just the AC_DEFINES stuff and leave out the rest later.

> 

[Gustavo Noronha (kov)]

Ping?

[Martin Robinson]

Closing this one as it's probably way out of date.