Bug 217291

Summary: Add non-animated support for the CSS scale property
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, changseok, clopez, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, graouts, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, pdr, ryuan.choi, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 178117    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Antoine Quint
Reported 2020-10-04 02:20:52 PDT
Add non-animated support for the CSS scale property
Attachments
Patch (201.51 KB, patch)
2020-10-04 02:24 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (206.71 KB, patch)
2020-10-04 11:33 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (207.24 KB, patch)
2020-10-05 00:17 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (207.81 KB, patch)
2020-10-05 00:29 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-04 02:21:22 PDT
<rdar://problem/69926254>
Antoine Quint
Comment 2 2020-10-04 02:24:52 PDT
Created attachment 410460 [details] Patch
EWS Watchlist
Comment 3 2020-10-04 02:25:34 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Antoine Quint
Comment 4 2020-10-04 11:33:21 PDT
Created attachment 410475 [details] Patch
Simon Fraser (smfr)
Comment 5 2020-10-04 11:47:45 PDT
Comment on attachment 410475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410475&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:643 > + if (!rendererCanBeTransformed(renderer) || is<RenderInline>(*renderer) || !scale) Doesn't rendererCanBeTransformed() check is<RenderInline>? > Source/WebCore/css/CSSProperties.json:6497 > + "url": "https://drafts.csswg.org/css-transforms-2/#propdef-translate" Wrong url. > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:182 > + RefPtr<ScaleTransformOperation> scale; StyleRareNonInheritedData is growing...
Antoine Quint
Comment 6 2020-10-05 00:17:51 PDT
Created attachment 410506 [details] Patch
Antoine Quint
Comment 7 2020-10-05 00:29:17 PDT
Created attachment 410507 [details] Patch
EWS
Comment 8 2020-10-05 01:46:21 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Antoine Quint
Comment 9 2020-10-05 02:46:50 PDT
Committed r267958: <https://trac.webkit.org/changeset/267958>
Note You need to log in before you can comment on or make changes to this bug.