Bug 217291

Summary: Add non-animated support for the CSS scale property
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, changseok, clopez, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, graouts, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, pdr, ryuan.choi, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 178117    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Description Antoine Quint 2020-10-04 02:20:52 PDT 
Add non-animated support for the CSS scale property
Comment 1 Radar WebKit Bug Importer 2020-10-04 02:21:22 PDT 
<rdar://problem/69926254>
Comment 2 Antoine Quint 2020-10-04 02:24:52 PDT 
Created attachment 410460 [details]
Patch
Comment 3 EWS Watchlist 2020-10-04 02:25:34 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Antoine Quint 2020-10-04 11:33:21 PDT 
Created attachment 410475 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-10-04 11:47:45 PDT 
Comment on attachment 410475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410475&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:643
> +    if (!rendererCanBeTransformed(renderer) || is<RenderInline>(*renderer) || !scale)

Doesn't rendererCanBeTransformed() check is<RenderInline>?

> Source/WebCore/css/CSSProperties.json:6497
> +                "url": "https://drafts.csswg.org/css-transforms-2/#propdef-translate"

Wrong url.

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:182
> +    RefPtr<ScaleTransformOperation> scale;

StyleRareNonInheritedData is growing...
Comment 6 Antoine Quint 2020-10-05 00:17:51 PDT 
Created attachment 410506 [details]
Patch
Comment 7 Antoine Quint 2020-10-05 00:29:17 PDT 
Created attachment 410507 [details]
Patch
Comment 8 EWS 2020-10-05 01:46:21 PDT 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 9 Antoine Quint 2020-10-05 02:46:50 PDT 
Committed r267958: <https://trac.webkit.org/changeset/267958>