Bug 217246 – TranslateTransformOperation shouldn't take in a FloatSize to convert z as a double

• Component: New Bugs
• Status: RESOLVED FIXED

[Antoine Quint]

TranslateTransformOperation shouldn't take in a FloatSize to convert z as a double

[Antoine Quint]

Created attachment 410358 [details]
Patch

[Darin Adler]

Comment on attachment 410358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410358&action=review

> Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h:53
> +    double xAsDouble(const FloatSize& borderBoxSize) const { return floatValueForLength(m_x, borderBoxSize.width()); }
> +    double yAsDouble(const FloatSize& borderBoxSize) const { return floatValueForLength(m_y, borderBoxSize.height()); }
> +    double zAsDouble() const { return floatValueForLength(m_z, 1); }

Strange mix here. We are calling something that computes a float, then converting it to a double when returning it, then it seems 2 of the 3 call sites call narrowPrecisionToFloat on a value that was just converted *from* a float. Maybe this should return float, not double?

[Radar WebKit Bug Importer]

<rdar://problem/70150086>

[Antoine Quint]

Created attachment 411771 [details]
Patch

[Antoine Quint]

Committed r268714: <https://trac.webkit.org/changeset/268714>