Bug 217204

Summary: Remove unhelpful dom-static-property-for-in-iteration.html test
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2020-10-01 18:57:12 PDT
Remove unhelpful dom-static-property-for-in-iteration.html test
Attachments
Patch (43.06 KB, patch)
2020-10-01 19:00 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-01 19:00:45 PDT
Created attachment 410300 [details] Patch
Sam Weinig
Comment 2 2020-10-01 19:01:18 PDT
Iteration order for builtin attributes, operations and constants of WebIDL objects is not currently defined, so the test dom-static-property-for-in-iteration.html,is just testing what we happen to currently do. This is largely unhelpfuland frustrating to maintain as different ports enabling/disabling featuresmeans each port needed a seperate result, and any time something was added, removedor moved, all the results need to be updated. There are plenty of other teststhat ensure we have these properties, so removing this is not a loss.
Sam Weinig
Comment 3 2020-10-01 19:01:56 PDT
Interested if others think this test remains useful, but I think we should just get rid of it.
EWS
Comment 4 2020-10-02 09:02:02 PDT
Committed r267884: <https://trac.webkit.org/changeset/267884> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410300 [details].
Note You need to log in before you can comment on or make changes to this bug.