Bug 217198 – Support EXT_texture_compression_rgtc WebGL extension

• Component: WebGL
• Status: RESOLVED FIXED

[James Darpinian]

Support EXT_texture_compression_rgtc WebGL extension

[James Darpinian]

Created attachment 410284 [details]
Patch

[James Darpinian]

Will add conformance test tomorrow.

[James Darpinian]

Created attachment 410383 [details]
Patch

[Kenneth Russell]

Comment on attachment 410383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410383&action=review

Looks great! One question. r+

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6739
> +        const int kBlockHeight = 4;

Have you confirmed that these values (from the extension spec) are correct, and that the tests both successfully enable the extension, and pass?

[James Darpinian]

Comment on attachment 410383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410383&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6739
>> +        const int kBlockHeight = 4;
> 
> Have you confirmed that these values (from the extension spec) are correct, and that the tests both successfully enable the extension, and pass?

Yes. Although the existing conformance test doesn't appear to load any images or do any rendering. So I guess we don't truly know if any existing implementation actually works. I will try to find some sample images.

[James Darpinian]

Created attachment 410704 [details]
Patch

[James Darpinian]

Comment on attachment 410704 [details]
Patch

Added very thorough rendering test based on the existing S3TC test.

[EWS]

Committed r268085: <https://trac.webkit.org/changeset/268085>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410704 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70022537>

[Aakash Jain]

(In reply to EWS from comment #8)
> Committed r268085: <https://trac.webkit.org/changeset/268085>
The newly added test: webgl/conformance/extensions/s3tc-and-rgtc.html seems to be consistently failing on ios-wk2. EWS indicated this failure on previous version of this patch. Should have waited for ios-wk2 EWS to complete before landing.

History: https://results.webkit.org/?suite=layout-tests&test=webgl%2Fconformance%2Fextensions%2Fs3tc-and-rgtc.html

[WebKit Commit Bot]

Re-opened since this is blocked by bug 217424

[Kenneth Russell]

From this run:
https://build.webkit.org/results/Apple-iOS-14-Simulator-Release-WK2-Tests/r268117%20(171)/results.html
https://build.webkit.org/results/Apple-iOS-14-Simulator-Release-WK2-Tests/r268117%20(171)/webgl/conformance/extensions/s3tc-and-rgtc-pretty-diff.html

it looks like the bug in the test is that it doesn't handle the case where the extension isn't available:

 1CONSOLE MESSAGE: TypeError: undefined is not an object (evaluating 'ext_rgtc.COMPRESSED_RED_RGTC1_EXT')

[James Darpinian]

Created attachment 410784 [details]
Patch

[James Darpinian]

Sorry for the breakage. The code to check whether the extension was supported was buggy. Will wait for EWS before relanding.

[Kenneth Russell]

Comment on attachment 410784 [details]
Patch

Looks good assuming the revised test has been tested locally when EXT_texture_compression_rgtc is not supported. r+

[James Darpinian]

Created attachment 410868 [details]
Patch

[EWS]

Committed r268234: <https://trac.webkit.org/changeset/268234>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410868 [details].