Bug 217162

Summary:

[WebIDL] Add support for non-nullable optional wrapper type arguments to operations

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

219165

Bug Blocks:

171589

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	cdumez: review+, sam: commit-queue+
Patch	none

Sam Weinig

Reported 2020-09-30 19:37:32 PDT

[WebIDL] Add support for non-nullable optional wrapper type arguments to operations

Attachments
Patch (12.87 KB, patch) 2020-09-30 19:54 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (38.57 KB, patch) 2020-10-01 09:53 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (39.82 KB, patch) 2020-10-01 11:29 PDT, Sam Weinig	cdumez: review+ sam: commit-queue+	Details Formatted Diff Diff
Patch (39.81 KB, patch) 2020-10-01 17:57 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2020-09-30 19:54:16 PDT

Created attachment 410197 [details] Patch

Sam Weinig

Comment 2 2020-10-01 09:53:25 PDT

Created attachment 410241 [details] Patch

Chris Dumez

Comment 3 2020-10-01 09:54:27 PDT

Comment on attachment 410241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410241&action=review > LayoutTests/ChangeLog:12 > +2020-09-30 Sam Weinig <weinig@apple.com> double changelog.

Sam Weinig

Comment 4 2020-10-01 11:24:11 PDT

(In reply to Chris Dumez from comment #3) > Comment on attachment 410241 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410241&action=review > > > LayoutTests/ChangeLog:12 > > +2020-09-30 Sam Weinig <weinig@apple.com> > > double changelog. No really close to ready for review yet. Just using the bots to build things for me while my computer is busy :).

Chris Dumez

Comment 5 2020-10-01 11:25:08 PDT

(In reply to Sam Weinig from comment #4) > (In reply to Chris Dumez from comment #3) > > Comment on attachment 410241 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=410241&action=review > > > > > LayoutTests/ChangeLog:12 > > > +2020-09-30 Sam Weinig <weinig@apple.com> > > > > double changelog. > > No really close to ready for review yet. Just using the bots to build things > for me while my computer is busy :). Yeah but I got curious and could not help but look :P

Sam Weinig

Comment 6 2020-10-01 11:29:28 PDT

(In reply to Chris Dumez from comment #5) > (In reply to Sam Weinig from comment #4) > > (In reply to Chris Dumez from comment #3) > > > Comment on attachment 410241 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=410241&action=review > > > > > > > LayoutTests/ChangeLog:12 > > > > +2020-09-30 Sam Weinig <weinig@apple.com> > > > > > > double changelog. > > > > No really close to ready for review yet. Just using the bots to build things > > for me while my computer is busy :). > > Yeah but I got curious and could not help but look :P It was good, I probably would have missed it :).

Sam Weinig

Comment 7 2020-10-01 11:29:36 PDT

Created attachment 410246 [details] Patch

Sam Weinig

Comment 8 2020-10-01 12:06:03 PDT

I think it should be ready for review now.

Chris Dumez

Comment 9 2020-10-01 12:21:52 PDT

Comment on attachment 410246 [details] Patch r=me

Chris Dumez

Comment 10 2020-10-01 16:22:04 PDT

Re-running Mac-wk2 EWS since I think the failing test is unrelated.

Sam Weinig

Comment 11 2020-10-01 17:57:06 PDT

Created attachment 410293 [details] Patch

EWS

Comment 12 2020-10-01 18:42:20 PDT

Committed r267865: <https://trac.webkit.org/changeset/267865> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410293 [details].

Chris Dumez

Comment 13 2020-11-19 08:56:08 PST

Comment on attachment 410293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410293&action=review > Source/WebCore/Modules/geolocation/Geolocation.idl:-35 > - optional PositionErrorCallback? errorCallback, I don't think we should have made those changes. Those parameters are nullable in both Firefox and Chrome. Also, there are WPT tests that fail unless this parameter is nullable. I am planning on reverting the changes to Geolocation.idl as a result.

Radar WebKit Bug Importer

Comment 14 2020-11-19 08:56:23 PST

<rdar://problem/71588509>

Note You need to log in before you can comment on or make changes to this bug.