Bug 217151

Summary: [webkitscmpy] Support git-svn committers
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Jonathan Bedard 2020-09-30 16:07:10 PDT 
git-svn styles committers in a way that breaks our regex extracting the committer. We should support git-svn's commit message style.
Comment 1 Radar WebKit Bug Importer 2020-09-30 16:07:23 PDT 
<rdar://problem/69812996>
Comment 2 Jonathan Bedard 2020-09-30 16:12:09 PDT 
Created attachment 410163 [details]
Patch
Comment 3 Jonathan Bedard 2020-09-30 16:14:55 PDT 
Created attachment 410166 [details]
Patch
Comment 4 Jonathan Bedard 2020-10-01 09:16:06 PDT 
Created attachment 410237 [details]
Patch
Comment 5 Aakash Jain 2020-10-01 10:36:43 PDT 
rs=me

Can you also check the error in https://ews-build.webkit.org/#/builders/5/builds/35586/steps/7/logs/stdio

IOError: [Errno 2] No such file or directory: u'/Volumes/Data/worker/WebKitPy-Tests-EWS/build/WebKitBuild/Release/layout-test-results/35417-python_stack_trace.txt'
Comment 6 Jonathan Bedard 2020-10-01 11:40:07 PDT 
(In reply to Aakash Jain from comment #5)
> rs=me
> 
> Can you also check the error in
> https://ews-build.webkit.org/#/builders/5/builds/35586/steps/7/logs/stdio
> 
> IOError: [Errno 2] No such file or directory:
> u'/Volumes/Data/worker/WebKitPy-Tests-EWS/build/WebKitBuild/Release/layout-
> test-results/35417-python_stack_trace.txt'

Will keep watching EWS for that, but it looks like we have a test that interrupts a subprocess which logs the stacktrace of the interrupted process to layout-test-results, but we aren't running layout tests, so the directory doesn't exist. What's surprising is that this error seems to be a one-off (the fact that it is not fatal is pretty common), will keep an eye on things to see if this is reoccurring issue.
Comment 7 Jonathan Bedard 2020-10-01 11:49:05 PDT 
Created attachment 410253 [details]
Patch for landing
Comment 8 EWS 2020-10-01 14:53:05 PDT 
Committed r267853: <https://trac.webkit.org/changeset/267853>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410253 [details].