Bug 217136

Summary: Floating-point math causes shrink-wrapped content to line wrap sometimes
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, eddie.chen, esprehn+autocc, ews-watchlist, glenn, Hironori.Fujii, koivisto, kondapallykalyan, mmaxfield, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test reduction
none
LFC screenshot
none
Patch none

Myles C. Maxfield
Reported 2020-09-30 11:43:39 PDT
See https://codepen.io/thiagoboa/pen/abNxRyE?editors=1100 There shouldn't be a line wrap. (lldb) p m_availableWidth (float) $18 = 104.5625 (lldb) p m_committedWidth + m_uncommittedWidth (float) $17 = 104.562508
Attachments
Test reduction (247 bytes, text/html)
2020-10-02 21:36 PDT, zalan 		no flags
Details
LFC screenshot (47.55 KB, image/png)
2020-10-02 21:38 PDT, zalan 		no flags
Details
Patch (3.07 KB, patch)
2020-10-03 07:05 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-09-30 11:50:45 PDT
Alan: Would LFC fix this?
Radar WebKit Bug Importer
Comment 2 2020-09-30 11:50:59 PDT
<rdar://problem/69801790>
zalan
Comment 3 2020-09-30 12:27:41 PDT
(In reply to Myles C. Maxfield from comment #1) > Alan: Would LFC fix this? In LFC the preferred width computation and the actual layout share the same codepath with different constrains, so I'd say yes.
zalan
Comment 4 2020-10-02 21:36:04 PDT
Created attachment 410411 [details] Test reduction
zalan
Comment 5 2020-10-02 21:38:31 PDT
Created attachment 410412 [details] LFC screenshot It is actually fixed in LFC (see screenshot).
zalan
Comment 6 2020-10-03 07:05:17 PDT
Created attachment 410414 [details] Patch
zalan
Comment 7 2020-10-03 07:11:41 PDT
will try to submit a test case. it needs a custom font with special geometries (to trigger the floating point issue)
Antti Koivisto
Comment 8 2020-10-03 07:17:57 PDT
Comment on attachment 410414 [details] Patch No test?
EWS
Comment 9 2020-10-03 08:02:28 PDT
Committed r267923: <https://trac.webkit.org/changeset/267923> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410414 [details].
Note You need to log in before you can comment on or make changes to this bug.