Bug 217066

Summary: Create an API for a page to ask if it should display a consent banner
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: NEW    
Severity: Normal CC: cdumez, dino, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Kate Cheney
Reported 2020-09-28 16:16:20 PDT
We should create API where sites can query to determine whether they should display various consent banners.
Attachments
Patch (42.79 KB, patch)
2020-09-28 16:26 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (45.87 KB, patch)
2020-09-30 11:55 PDT, Kate Cheney 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-09-28 16:17:39 PDT
<rdar://problem/69722542>
Kate Cheney
Comment 2 2020-09-28 16:26:54 PDT
Created attachment 409927 [details] Patch
Sam Weinig
Comment 3 2020-09-28 16:33:33 PDT
Is this based on a spec?
Kate Cheney
Comment 4 2020-09-30 11:55:30 PDT
Created attachment 410143 [details] Patch
Kate Cheney
Comment 5 2020-09-30 11:56:07 PDT
(In reply to Sam Weinig from comment #3) > Is this based on a spec? No. It is now behind an experimental feature flag which is off by default.
Sam Weinig
Comment 6 2020-09-30 13:42:27 PDT
This is quite hard to review without either a spec to follow or some explanation of what the intended behavior is. Can you write up a more detailed explanation about what this is all about? What even is a "consent banner"?
Dean Jackson
Comment 7 2020-09-30 19:26:56 PDT
What is the consent for? The API is just "shouldShowConsentBanner()" on Document, but no details on what that means. Also, how does a Document show a consent banner? This is the API for asking if it should. I would have expected the feature to develop the other way around - with the actual consent banner landing first. I think this patch needs a description of what the feature is, and why it is different from the standard permissions API (https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API). Even if it isn't something that can fit in there, it would be worth making this new thing follow the same design as Permissions (you don't ask if you can ask - you would ask if you have consent). In fact, Permissions has a possible value of "prompt", which sounds a lot like what you're asking. One snag is the permissions API is on navigator, whereas this patch is adding to Document.
Note You need to log in before you can comment on or make changes to this bug.