Bug 217049

Summary: Fix test failures inadventently introduced in r267644
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, darin, keith_miller, mark.lam, ross.kirsling, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Angelos Oikonomopoulos
Reported 2020-09-28 03:20:45 PDT
Fix test failures inadventently introduced in r267644
Attachments
Patch (2.73 KB, patch)
2020-09-28 03:23 PDT, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (2.90 KB, patch)
2020-09-28 03:33 PDT, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2020-09-28 03:23:47 PDT
Created attachment 409878 [details] Patch
Angelos Oikonomopoulos
Comment 2 2020-09-28 03:33:43 PDT
Created attachment 409881 [details] Patch
EWS
Comment 3 2020-09-28 05:25:05 PDT
Committed r267696: <https://trac.webkit.org/changeset/267696> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409881 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-28 05:26:16 PDT
<rdar://problem/69693227>
Darin Adler
Comment 5 2020-09-28 08:19:20 PDT
Comment on attachment 409881 [details] Patch It doesn’t make sense that these would lead to test failures. The test tool would strip the spaces. These scripts would not be able to detect that the spaces were stripped. Did tests really fail? How?
Darin Adler
Comment 6 2020-09-28 10:33:57 PDT
Oh, I think I understand. These were broken when they were run, not with DumpRenderTree or WebKitTestRunner, but in some other JavaScript-only way.
Angelos Oikonomopoulos
Comment 7 2020-09-29 01:09:28 PDT
(In reply to Darin Adler from comment #6) > Oh, I think I understand. These were broken when they were run, not with > DumpRenderTree or WebKitTestRunner, but in some other JavaScript-only way. Right, those are getting run by run-jsc-stress-tests.
Note You need to log in before you can comment on or make changes to this bug.