| Summary: | [LFC][Floats] Add support for clear on float box | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-09-27 20:14:12 PDT
Created attachment 409867 [details]
Patch
Comment on attachment 409867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409867&action=review > Source/WebCore/layout/floats/FloatingContext.cpp:262 > + auto floatBottom = Optional<PositionInContextRoot> { }; > + switch (layoutBox.style().clear()) { > + case Clear::Left: > + floatBottom = floatingState().leftBottom(root()); > + break; > + case Clear::Right: > + floatBottom = floatingState().rightBottom(root()); > + break; > + case Clear::Both: > + floatBottom = floatingState().bottom(root()); > + break; > + default: > + ASSERT_NOT_REACHED(); > + } No lambda? Created attachment 409885 [details]
Patch
(In reply to Antti Koivisto from comment #2) > Comment on attachment 409867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409867&action=review > > > Source/WebCore/layout/floats/FloatingContext.cpp:262 > > + auto floatBottom = Optional<PositionInContextRoot> { }; > > + switch (layoutBox.style().clear()) { > > + case Clear::Left: > > + floatBottom = floatingState().leftBottom(root()); > > + break; > > + case Clear::Right: > > + floatBottom = floatingState().rightBottom(root()); > > + break; > > + case Clear::Both: > > + floatBottom = floatingState().bottom(root()); > > + break; > > + default: > > + ASSERT_NOT_REACHED(); > > + } > > No lambda? Certainly an oversight on my part. Committed r267700: <https://trac.webkit.org/changeset/267700> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409885 [details]. |