Bug 217045

Summary: [LFC][Floats] Add support for clear on float box
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2020-09-27 20:14:12 PDT
<div style="float: left; clear: both">
Attachments
Patch (12.66 KB, patch)
2020-09-27 20:33 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.69 KB, patch)
2020-09-28 07:36 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-09-27 20:33:45 PDT
Created attachment 409867 [details] Patch
Antti Koivisto
Comment 2 2020-09-28 06:31:29 PDT
Comment on attachment 409867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409867&action=review > Source/WebCore/layout/floats/FloatingContext.cpp:262 > + auto floatBottom = Optional<PositionInContextRoot> { }; > + switch (layoutBox.style().clear()) { > + case Clear::Left: > + floatBottom = floatingState().leftBottom(root()); > + break; > + case Clear::Right: > + floatBottom = floatingState().rightBottom(root()); > + break; > + case Clear::Both: > + floatBottom = floatingState().bottom(root()); > + break; > + default: > + ASSERT_NOT_REACHED(); > + } No lambda?
zalan
Comment 3 2020-09-28 07:36:50 PDT
Created attachment 409885 [details] Patch
zalan
Comment 4 2020-09-28 07:37:53 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 409867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409867&action=review > > > Source/WebCore/layout/floats/FloatingContext.cpp:262 > > + auto floatBottom = Optional<PositionInContextRoot> { }; > > + switch (layoutBox.style().clear()) { > > + case Clear::Left: > > + floatBottom = floatingState().leftBottom(root()); > > + break; > > + case Clear::Right: > > + floatBottom = floatingState().rightBottom(root()); > > + break; > > + case Clear::Both: > > + floatBottom = floatingState().bottom(root()); > > + break; > > + default: > > + ASSERT_NOT_REACHED(); > > + } > > No lambda? Certainly an oversight on my part.
EWS
Comment 5 2020-09-28 08:00:18 PDT
Committed r267700: <https://trac.webkit.org/changeset/267700> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409885 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-28 08:01:21 PDT
<rdar://problem/69698893>
Note You need to log in before you can comment on or make changes to this bug.