Bug 217028

Summary:

Refactor test runner code to cut down on copy/paste code and long-winded repetitive idioms

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Tools / Tests

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ews-watchlist, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	sam: review+

Darin Adler

Reported 2020-09-26 22:21:33 PDT

Refactor test runner code to cut down on copy/paste code and long-winded repetitive idioms

Attachments
Patch (676.39 KB, patch) 2020-09-27 11:46 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (676.70 KB, patch) 2020-09-27 11:51 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (681.29 KB, patch) 2020-09-27 11:57 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (681.47 KB, patch) 2020-09-27 12:44 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (681.30 KB, patch) 2020-09-27 12:50 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (681.30 KB, patch) 2020-09-27 12:55 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (683.27 KB, patch) 2020-09-27 15:02 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (683.24 KB, patch) 2020-09-27 18:46 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (688.20 KB, patch) 2020-09-27 18:55 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (688.25 KB, patch) 2020-09-27 21:47 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (688.56 KB, patch) 2020-09-27 23:06 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (687.27 KB, patch) 2020-09-28 09:57 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (692.31 KB, patch) 2020-09-28 19:35 PDT, Darin Adler	sam: review+	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2020-09-27 11:46:40 PDT Comment hidden (obsolete)

Created attachment 409849 [details] Patch

Darin Adler

Comment 2 2020-09-27 11:47:06 PDT

Not setting review? yet because I must have made at least one mistake in all the global replaces and refactoring.

Darin Adler

Comment 3 2020-09-27 11:51:48 PDT Comment hidden (obsolete)

Created attachment 409850 [details] Patch

Darin Adler

Comment 4 2020-09-27 11:57:09 PDT Comment hidden (obsolete)

Created attachment 409851 [details] Patch

Darin Adler

Comment 5 2020-09-27 12:44:44 PDT Comment hidden (obsolete)

Created attachment 409853 [details] Patch

Darin Adler

Comment 6 2020-09-27 12:50:39 PDT Comment hidden (obsolete)

Created attachment 409854 [details] Patch

Darin Adler

Comment 7 2020-09-27 12:55:13 PDT Comment hidden (obsolete)

Created attachment 409855 [details] Patch

Darin Adler

Comment 8 2020-09-27 15:02:47 PDT Comment hidden (obsolete)

Created attachment 409860 [details] Patch

Darin Adler

Comment 9 2020-09-27 18:46:52 PDT Comment hidden (obsolete)

Created attachment 409864 [details] Patch

Darin Adler

Comment 10 2020-09-27 18:55:49 PDT Comment hidden (obsolete)

Created attachment 409865 [details] Patch

Darin Adler

Comment 11 2020-09-27 21:47:45 PDT Comment hidden (obsolete)

Created attachment 409868 [details] Patch

Darin Adler

Comment 12 2020-09-27 23:06:47 PDT Comment hidden (obsolete)

Created attachment 409870 [details] Patch

Darin Adler

Comment 13 2020-09-28 09:57:13 PDT Comment hidden (obsolete)

Created attachment 409891 [details] Patch

Darin Adler

Comment 14 2020-09-28 19:35:47 PDT

Created attachment 409952 [details] Patch

Darin Adler

Comment 15 2020-09-29 13:12:12 PDT

Working now, so ready for review.

Sam Weinig

Comment 16 2020-09-29 14:15:06 PDT

Comment on attachment 409952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409952&action=review > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:96 > +static JSContextRef mainJSContext() I would prefer this be called mainFrameJSContext, just because main on its own is so ambiguous, but I feel this in a very minor way.

Darin Adler

Comment 17 2020-09-29 14:39:03 PDT

Committed r267761: <https://trac.webkit.org/changeset/267761>

Radar WebKit Bug Importer

Comment 18 2020-09-29 14:40:22 PDT

<rdar://problem/69764444>

Note You need to log in before you can comment on or make changes to this bug.