Bug 217023

Summary: [LFC][IFC] Create inline boxes for hard line breaks(<br>) and word wrap opportunities (<wbr>)
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

zalan
Reported 2020-09-26 20:16:10 PDT
so that we can add computed box geometries for them.
Attachments
Patch (13.82 KB, patch)
2020-09-26 20:44 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.60 KB, patch)
2020-09-26 21:29 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2020-09-27 09:07 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-09-26 20:44:46 PDT
Created attachment 409808 [details] Patch
zalan
Comment 2 2020-09-26 21:29:30 PDT
Created attachment 409811 [details] Patch
EWS
Comment 3 2020-09-27 06:03:33 PDT
Committed r267657: <https://trac.webkit.org/changeset/267657> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409811 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-27 06:04:18 PDT
<rdar://problem/69654918>
zalan
Comment 5 2020-09-27 09:07:57 PDT
Reopening to attach new patch.
zalan
Comment 6 2020-09-27 09:07:58 PDT
Created attachment 409837 [details] Patch
EWS
Comment 7 2020-09-27 09:30:59 PDT
Committed r267666: <https://trac.webkit.org/changeset/267666> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409837 [details].
Simon Fraser (smfr)
Comment 8 2020-09-27 10:47:49 PDT
Comment on attachment 409811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409811&action=review > Source/WebCore/layout/FormattingState.cpp:55 > + // Anonymous text wrappers do not need display boxes. You mean "do not need box geometry"? This is not about Display::Box.
zalan
Comment 9 2020-09-27 11:42:16 PDT
(In reply to Simon Fraser (smfr) from comment #8) > Comment on attachment 409811 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409811&action=review > > > Source/WebCore/layout/FormattingState.cpp:55 > > + // Anonymous text wrappers do not need display boxes. > > You mean "do not need box geometry"? This is not about Display::Box. Yeah, you are right. I should have rephrased it (this comment is from before when box geometry was really just a Display::Box)
Note You need to log in before you can comment on or make changes to this bug.