Bug 216988

Summary: Drop AudioNode::setNodeType()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611, 216989    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-09-25 12:53:01 PDT 
Drop AudioNode::setNodeType() in favor of passing the NodeType to the AudioNode constructor. This makes sure we never forget to set the type.
Comment 1 Chris Dumez 2020-09-25 13:00:10 PDT 
Created attachment 409725 [details]
Patch
Comment 2 Chris Dumez 2020-09-25 13:10:47 PDT 
Created attachment 409727 [details]
Patch
Comment 3 Eric Carlson 2020-09-25 15:57:00 PDT 
Comment on attachment 409727 [details]
Patch

rs=me
Comment 4 Chris Dumez 2020-09-25 16:03:07 PDT 
Comment on attachment 409727 [details]
Patch

Clearing flags on attachment: 409727

Committed r267604: <https://trac.webkit.org/changeset/267604>
Comment 5 Chris Dumez 2020-09-25 16:03:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-09-25 16:04:20 PDT 
<rdar://problem/69599144>