Bug 216966

Summary: [JSC] Introduce JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION to make host function definition easy-to-scanned for JIT-caging
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, ashvayka, beidson, benjamin, calvaris, cdumez, cmarcelo, ews-watchlist, hi, joepeck, jsbell, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
saam: review+, ews-feeder: commit-queue-
Patch none

Yusuke Suzuki
Reported 2020-09-25 01:20:39 PDT
[JSC] Introduce JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION to make host function definition easy-to-scanned for JIT-caging
Attachments
Patch (1.70 MB, patch)
2020-09-25 01:26 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.70 MB, patch)
2020-09-25 01:38 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (1.78 MB, patch)
2020-09-25 01:47 PDT, Yusuke Suzuki 		saam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.78 MB, patch)
2020-09-25 12:22 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-09-25 01:26:39 PDT
Created attachment 409666 [details] Patch
Yusuke Suzuki
Comment 2 2020-09-25 01:38:14 PDT
Created attachment 409667 [details] Patch
Yusuke Suzuki
Comment 3 2020-09-25 01:47:43 PDT
Created attachment 409668 [details] Patch
Saam Barati
Comment 4 2020-09-25 06:24:44 PDT
Comment on attachment 409668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409668&action=review > Source/WTF/wtf/PlatformCallingConventions.h:49 > +#define JSC_ANNOTATE_HOST_FUNCTION(functionId, function) This will do something in the future?
Yusuke Suzuki
Comment 5 2020-09-25 12:21:31 PDT
(In reply to Saam Barati from comment #4) > Comment on attachment 409668 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409668&action=review > > > Source/WTF/wtf/PlatformCallingConventions.h:49 > > +#define JSC_ANNOTATE_HOST_FUNCTION(functionId, function) > > This will do something in the future? Yes
Yusuke Suzuki
Comment 6 2020-09-25 12:22:27 PDT
Created attachment 409719 [details] Patch
Yusuke Suzuki
Comment 7 2020-09-25 14:23:54 PDT
stress/put-private-name-invalid-define.js.ftl-eager is flaky before this patch. Landing this now.
Yusuke Suzuki
Comment 8 2020-09-25 14:32:32 PDT
Committed r267594: <https://trac.webkit.org/changeset/267594>
Radar WebKit Bug Importer
Comment 9 2020-09-25 14:33:22 PDT
<rdar://problem/69594503>
Alexey Shvayka
Comment 10 2020-09-26 14:52:19 PDT
Comment on attachment 409719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409719&action=review > Source/JavaScriptCore/ChangeLog:199 It would be nice to tweak ChangeLog generation tool so the host function names are displayed correctly.
Note You need to log in before you can comment on or make changes to this bug.