Bug 216889

Summary: Notify igalia team about pre-existing test failures and build failures for JSC queues
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, guijemont, jbedard, pmatos, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215948
https://bugs.webkit.org/show_bug.cgi?id=217052
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-09-23 11:14:04 PDT
Notify igalia team about pre-existing test failures and build failures for JSC queues.
Attachments
Patch (4.45 KB, patch)
2020-09-23 11:17 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-09-23 11:17:49 PDT
Created attachment 409487 [details] Patch
Jonathan Bedard
Comment 2 2020-09-23 11:19:18 PDT
Comment on attachment 409487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409487&action=review > Tools/BuildSlaveSupport/ews-build/emails.json:10 > + "jsc32@igalia.com" Looks fine, but I would like someone from Igalia to verify they want this before we land it.
Jonathan Bedard
Comment 3 2020-09-23 11:54:37 PDT
(In reply to Jonathan Bedard from comment #2) > Comment on attachment 409487 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409487&action=review > > > Tools/BuildSlaveSupport/ews-build/emails.json:10 > > + "jsc32@igalia.com" > > Looks fine, but I would like someone from Igalia to verify they want this > before we land it. Looks like Igalia already verified in Slack that they want this.
EWS
Comment 4 2020-09-23 12:07:14 PDT
Committed r267492: <https://trac.webkit.org/changeset/267492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409487 [details].
Radar WebKit Bug Importer
Comment 5 2020-09-23 12:08:17 PDT
<rdar://problem/69450105>
Guillaume Emont
Comment 6 2020-09-23 12:34:53 PDT
Comment on attachment 409487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409487&action=review >>> Tools/BuildSlaveSupport/ews-build/emails.json:10 >>> + "jsc32@igalia.com" >> >> Looks fine, but I would like someone from Igalia to verify they want this before we land it. > > Looks like Igalia already verified in Slack that they want this. Don't know if there's better naming to be had, but technically, that's not the whole jsc team, but only the ones working on embedded/32-bit things. We also have people doing feature work who are not included in that email. Maybe I'm being too pedantic though ;).
Aakash Jain
Comment 7 2020-09-23 12:44:41 PDT
(In reply to Guillaume Emont from comment #6) > Don't know if there's better naming to be had, but technically, that's not the whole jsc team, but only the ones working on embedded/32-bit things. We also have people doing feature work who are not included in that email. Maybe I'm being too pedantic though ;). I guess specific name doesn't matter so much here. Feel free to change it to a better name though.
Aakash Jain
Comment 8 2020-09-23 13:01:57 PDT
Restarted buildbot to pick up this change.
Note You need to log in before you can comment on or make changes to this bug.