Bug 216863

Summary: Unify debug and release target aliases
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ddkilzer, jbedard, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-09-22 19:29:11 PDT
Some Makefiles have "debug", "d", "release", and "r" for build targets. Others also include "dev", "develop", "development", "dep", "deploy", and "deployment". Because of this inconsistency, trying to use those additional targets didn't work. It looks like all Makefiles used to support all of those targets, but some got dropped along the way. For instance, the top-level Makefile and Source/Makefile dropped them in 2013 as part of Bug 107863. And it looks like WebKitLibraries/Makefile never had them. Given that those additional targets don't work, it seems like no one uses them, so let's remove them completely.
Attachments
Patch (5.55 KB, patch)
2020-09-22 19:33 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-09-22 19:29:25 PDT
<rdar://problem/69407746>
Keith Rollin
Comment 2 2020-09-22 19:33:11 PDT
Created attachment 409443 [details] Patch
EWS
Comment 3 2020-09-22 20:38:22 PDT
Committed r267458: <https://trac.webkit.org/changeset/267458> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409443 [details].
Note You need to log in before you can comment on or make changes to this bug.