Summary: | Missing scope release in JSDOMBuiltinConstructorBase | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||||||||||
Component: | WebCore JavaScript | Assignee: | Tadeu Zagallo <tzagallo> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, rniwa, ryanhaddad, webkit-bug-importer, webkit.review.bot, ysuzuki | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 216924 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Tadeu Zagallo
2020-09-22 15:11:36 PDT
Created attachment 409407 [details]
Patch
Comment on attachment 409407 [details]
Patch
r=me
Found 1 new test failure: js/transform-stream.html Created attachment 409490 [details]
Patch for landing
Committed r267495: <https://trac.webkit.org/changeset/267495> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409490 [details]. Committed r267512: <https://trac.webkit.org/changeset/267512> (In reply to EWS from comment #5) > Committed r267495: <https://trac.webkit.org/changeset/267495> js/transform-stream.html was failing since r267495 (as also warned by EWS) on windows. History: https://results.webkit.org/?suite=layout-tests&test=js%2Ftransform-stream.html Yusuke commit in r267512 moved it to js/dom/transform-stream.html, but it is failing. History: https://results.webkit.org/?suite=layout-tests&test=js%2Fdom%2Ftransform-stream.html Re-opened since this is blocked by bug 216924 Created attachment 424612 [details]
Patch
Created attachment 424644 [details]
Patch
Comment on attachment 424644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424644&action=review > LayoutTests/ChangeLog:9 > + * js/script-tests/transform-stream.js: Added. Can we just inline this into transform-stream.html? > LayoutTests/js/dom/script-tests/transform-stream.js:3 > +description( > +"Tests exception checking in JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments." > +); Maybe put ( ~ ) in a single line? Created attachment 424849 [details]
Patch for landing
Committed r275333: <https://commits.webkit.org/r275333> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424849 [details]. |