Summary: | [macOS] Issue sandbox extension for the diagnostic daemon | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bfulgham, mitz, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2020-09-22 10:19:39 PDT
Created attachment 409383 [details]
Patch
*** Bug 206115 has been marked as a duplicate of this bug. *** Created attachment 409385 [details]
Patch
Comment on attachment 409385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409385&action=review r=me, but I think you could use an existing FileSystem function instead of the raw 'stat' operation. > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:68 > +#import <sys/stat.h> You don't need to include this if you use , FileSystem::fileIsDirectory > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:211 > + static bool isInternal = !stat("/AppleInternal", &st); I think it might be better to do: static bool isInternal = FileSystem::fileIsDirectory("/AppleInternal", FileSystem::ShouldFollowSymbolicLinks::No); Created attachment 409488 [details]
Patch
(In reply to Brent Fulgham from comment #5) > Comment on attachment 409385 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409385&action=review > > r=me, but I think you could use an existing FileSystem function instead of > the raw 'stat' operation. > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:68 > > +#import <sys/stat.h> > > You don't need to include this if you use , FileSystem::fileIsDirectory > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:211 > > + static bool isInternal = !stat("/AppleInternal", &st); > > I think it might be better to do: > > static bool isInternal = FileSystem::fileIsDirectory("/AppleInternal", > FileSystem::ShouldFollowSymbolicLinks::No); Will fix, thanks for reviewing! Created attachment 409489 [details]
Patch
Committed r267498: <https://trac.webkit.org/changeset/267498> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409489 [details]. Comment on attachment 409385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409385&action=review >> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:211 >> + static bool isInternal = !stat("/AppleInternal", &st); > > I think it might be better to do: > > static bool isInternal = FileSystem::fileIsDirectory("/AppleInternal", FileSystem::ShouldFollowSymbolicLinks::No); Either way it’s not the recommended way to test whether a computer is running the Apple-internal version of macOS. See OSVariantSPI.h in WTF. (In reply to mitz from comment #10) > Comment on attachment 409385 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409385&action=review > > >> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:211 > >> + static bool isInternal = !stat("/AppleInternal", &st); > > > > I think it might be better to do: > > > > static bool isInternal = FileSystem::fileIsDirectory("/AppleInternal", FileSystem::ShouldFollowSymbolicLinks::No); > > Either way it’s not the recommended way to test whether a computer is > running the Apple-internal version of macOS. See OSVariantSPI.h in WTF. Ah, thanks! I will look into that. Created attachment 409584 [details]
Patch
Created attachment 409585 [details]
Patch
|