Bug 216738

Summary:

Change render tree selection painting code to use non-canonicalized points

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

HTML Editing

Assignee:

Darin Adler <darin>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ews-watchlist, mifenton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=216325

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-

Darin Adler

Reported 2020-09-19 18:38:34 PDT

Selection API: Remove unneeded incorrect code that overwrites the base and extent of a selection based on visibility

Attachments
Patch (6.84 KB, patch) 2020-09-19 18:42 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2020-09-19 18:42:33 PDT

Created attachment 409220 [details] Patch

Darin Adler

Comment 2 2020-09-20 14:36:11 PDT

OK, turns out I misunderstood the code here. It’s calling a setSelection function on the render tree, which should not have any effect on the selection in the DOM. But somehow it did have an effect. Need to restore the old code and figure out what was happening.

Darin Adler

Comment 3 2020-09-20 21:42:14 PDT

Not sure I need to do this any time soon. It’s nice to improve how we tie painting the selection to the DOM to not rely on so much editing strangeness. But not needed for the Selection API project.

Radar WebKit Bug Importer

Comment 4 2020-09-26 18:39:15 PDT

<rdar://problem/69639857>

Darin Adler

Comment 5 2025-10-11 16:46:28 PDT

I’m not going to use this bug report to do anything. Someone might resolve this some day, but we don’t need to keep this bug open.

Note You need to log in before you can comment on or make changes to this bug.