Bug 216694

Summary: [LFC][FFC] Add flex box/item to showLayoutTree
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2020-09-18 03:47:20 PDT
ssia
Attachments
Patch (1.88 KB, patch)
2020-09-18 03:49 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2020-09-18 16:47 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-09-18 03:49:55 PDT
Created attachment 409125 [details] Patch
Sam Weinig
Comment 2 2020-09-18 10:32:23 PDT
Comment on attachment 409125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409125&action=review > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:453 > + stream << "Fkex box"; typo. Fkex -> Flex
alan
Comment 3 2020-09-18 10:33:36 PDT
(In reply to Sam Weinig from comment #2) > Comment on attachment 409125 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409125&action=review > > > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:453 > > + stream << "Fkex box"; > > typo. Fkex -> Flex never post patches at 4am.
alan
Comment 4 2020-09-18 16:47:48 PDT
Created attachment 409179 [details] Patch
EWS
Comment 5 2020-09-18 17:40:44 PDT
Committed r267303: <https://trac.webkit.org/changeset/267303> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409179 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-18 17:41:15 PDT
<rdar://problem/69185543>
Simon Fraser (smfr)
Comment 7 2020-09-18 20:10:35 PDT
Layout::Boxes need a virtual String debugDescription() const so they can print themselves.
alan
Comment 8 2020-09-19 05:45:54 PDT
(In reply to Simon Fraser (smfr) from comment #7) > Layout::Boxes need a virtual String debugDescription() const so they can > print themselves. Since the LayoutBox has a rather flat class hierarchy (LFC tree is not typed as heavily as the render tree) we would probably end up with a big switch in Layout::Box. I'd rather keep it separate for now.
Note You need to log in before you can comment on or make changes to this bug.