Bug 216674

Summary: Per-app accent color overrides are broken
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Tim Horton 2020-09-17 16:44:27 PDT 
Per-app accent color overrides are broken
Comment 1 Tim Horton 2020-09-17 16:44:43 PDT 
Created attachment 409086 [details]
Patch
Comment 2 Tim Horton 2020-09-17 16:44:45 PDT 
<rdar://problem/67745464>
Comment 3 Darin Adler 2020-09-17 17:49:36 PDT 
Comment on attachment 409086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409086&action=review

> Source/WebCore/PAL/pal/spi/mac/NSApplicationSPI.h:39
>  @property (copy, setter=_setAccentColor:) NSColor *_accentColor;

Can we remove this, too?
Comment 4 EWS 2020-09-17 17:50:22 PDT 
Committed r267215: <https://trac.webkit.org/changeset/267215>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409086 [details].
Comment 5 Tim Horton 2020-09-17 17:58:52 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 409086 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409086&action=review
> 
> > Source/WebCore/PAL/pal/spi/mac/NSApplicationSPI.h:39
> >  @property (copy, setter=_setAccentColor:) NSColor *_accentColor;
> 
> Can we remove this, too?

No, we can't, we still use the setter!