Summary: | results.webkit.org: Use s3 for cold storage | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | aakash_jain, ap, lingho, ryanhaddad, webkit-bug-importer | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | All | ||||||||||||||||||
OS: | All | ||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=207277 | ||||||||||||||||||
Attachments: |
|
Description
Jonathan Bedard
2020-09-17 13:26:42 PDT
Created attachment 409063 [details]
Patch
Created attachment 409085 [details]
Patch
Created attachment 409334 [details]
Patch
Created attachment 409381 [details]
Patch
Comment on attachment 409381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409381&action=review rs=me is this tested? > Tools/ChangeLog:24 > + (S3Archiver.save): Save an archive to S3 by it's hash. Nit: it's => its > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:59 > + ttl_seconds = ttl_seconds or 60 * 60 * 24 * 365 might be a good idea to store this time limit (1 year) in a separate variable, and use that variable here. (In reply to Aakash Jain from comment #6) > Comment on attachment 409381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409381&action=review > > rs=me > > is this tested? > > > Tools/ChangeLog:24 > > + (S3Archiver.save): Save an archive to S3 by it's hash. > > Nit: it's => its > > > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:59 > > + ttl_seconds = ttl_seconds or 60 * 60 * 24 * 365 > > might be a good idea to store this time limit (1 year) in a separate > variable, and use that variable here. Not tested in an automated way, because that would entail mocking S3's API, and I didn't think it was worth the trouble. I did deploy this to our staging instances, though. Created attachment 409422 [details]
Patch
Created attachment 409621 [details]
Patch
Created attachment 409702 [details]
Patch
Committed r267579: <https://trac.webkit.org/changeset/267579> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409702 [details]. |