| Summary: | AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 212611 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Dumez
2020-09-16 18:05:11 PDT
Created attachment 408972 [details]
Patch
Created attachment 408982 [details]
Patch
Comment on attachment 408982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408982&action=review > Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:214 > float* destination = destinationArray.data(); auto > Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:218 > destination[i] = static_cast<float>(dbMag); linearToDecibels returns a float, so there is probably no need for this double to float cast. One liner: destination[i] = AudioUtilities::linearToDecibels(source[i]); > Source/WebCore/platform/audio/AudioUtilities.cpp:45 > } Might be worth inlining Created attachment 409034 [details]
Patch
Created attachment 409040 [details]
Patch
Committed r267202: <https://trac.webkit.org/changeset/267202> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409040 [details]. |