Bug 216629

Summary: AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-09-16 18:05:11 PDT
AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent.
Attachments
Patch (4.65 KB, patch)
2020-09-16 18:07 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.48 KB, patch)
2020-09-16 19:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.55 KB, patch)
2020-09-17 08:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.54 KB, patch)
2020-09-17 09:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-16 18:07:02 PDT
Created attachment 408972 [details] Patch
Chris Dumez
Comment 2 2020-09-16 19:41:21 PDT
Created attachment 408982 [details] Patch
youenn fablet
Comment 3 2020-09-17 01:09:29 PDT
Comment on attachment 408982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408982&action=review > Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:214 > float* destination = destinationArray.data(); auto > Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:218 > destination[i] = static_cast<float>(dbMag); linearToDecibels returns a float, so there is probably no need for this double to float cast. One liner: destination[i] = AudioUtilities::linearToDecibels(source[i]); > Source/WebCore/platform/audio/AudioUtilities.cpp:45 > } Might be worth inlining
Chris Dumez
Comment 4 2020-09-17 08:36:03 PDT
Created attachment 409034 [details] Patch
Chris Dumez
Comment 5 2020-09-17 09:17:03 PDT
Created attachment 409040 [details] Patch
EWS
Comment 6 2020-09-17 11:39:29 PDT
Committed r267202: <https://trac.webkit.org/changeset/267202> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409040 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-17 11:40:17 PDT
<rdar://problem/69084553>
Note You need to log in before you can comment on or make changes to this bug.