Bug 216608

Summary: Remove the legacy animation code
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, changseok, cmarcelo, dino, dstockwell, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, gyuyoung.kim, kangil.han, kondapallykalyan, luiz, macpherson, menard, noam, pdr, ryuan.choi, sam, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Antoine Quint
Reported 2020-09-16 07:11:06 PDT
Remove the legacy animation code
Attachments
Patch (536.37 KB, patch)
2020-09-16 07:20 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (539.79 KB, patch)
2020-09-16 07:35 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (545.48 KB, patch)
2020-09-16 09:40 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (545.13 KB, patch)
2020-09-16 10:06 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (546.52 KB, patch)
2020-09-16 11:38 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (515.80 KB, patch)
2020-09-16 12:22 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (521.35 KB, patch)
2020-09-16 12:56 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (521.74 KB, patch)
2020-09-16 13:40 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (520.47 KB, patch)
2020-09-17 03:48 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (520.73 KB, patch)
2020-09-17 04:12 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-09-16 07:20:01 PDT
Created attachment 408920 [details] Patch
Antoine Quint
Comment 2 2020-09-16 07:35:30 PDT
Created attachment 408921 [details] Patch
Antoine Quint
Comment 3 2020-09-16 08:51:19 PDT
Looks like I broke computed style for transform and filter, both accelerated properties.
Antoine Quint
Comment 4 2020-09-16 09:40:16 PDT
Created attachment 408928 [details] Patch
Antoine Quint
Comment 5 2020-09-16 10:06:44 PDT
Created attachment 408931 [details] Patch
Antoine Quint
Comment 6 2020-09-16 10:07:16 PDT
Filed bug 216612 to look into the GTK / WPE build failures which seem to be a bug in the code generation for IDL files.
Antoine Quint
Comment 7 2020-09-16 11:38:13 PDT
Created attachment 408938 [details] Patch
Antoine Quint
Comment 8 2020-09-16 12:22:28 PDT
Created attachment 408941 [details] Patch
Antoine Quint
Comment 9 2020-09-16 12:56:56 PDT
Created attachment 408945 [details] Patch
Antoine Quint
Comment 10 2020-09-16 13:40:04 PDT
Created attachment 408952 [details] Patch
Antoine Quint
Comment 11 2020-09-17 03:48:01 PDT
Created attachment 409018 [details] Patch
Antoine Quint
Comment 12 2020-09-17 04:12:44 PDT
Created attachment 409020 [details] Patch
Antoine Quint
Comment 13 2020-09-17 05:25:29 PDT
The test failures on the Windows bots don't seem related to this patch. A local Windows build manages to pass animation tests that otherwise showed as a Crash. Note that the Windows build required a manual clean build on the bot to succeed. Same goes for WPE and GTK builds, though I managed to get the EWS bots to build by making a dummy change to ShadowRoot.idl. This is covered by bug 216612. Going to land the patch as I believe it to be OK with the caveats listed above.
Antoine Quint
Comment 14 2020-09-17 05:39:40 PDT
Committed r267188: <https://trac.webkit.org/changeset/267188>
Radar WebKit Bug Importer
Comment 15 2020-09-17 05:40:18 PDT
<rdar://problem/69063339>
Note You need to log in before you can comment on or make changes to this bug.