Bug 216606

Summary: [Flatpak SDK] bwrap: add pipewire socket as bind mount
Product: WebKit Reporter: Víctor M. Jáquez L. <vjaquez>
Component: Tools / TestsAssignee: Víctor M. Jáquez L. <vjaquez>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Víctor M. Jáquez L.
Reported 2020-09-16 03:32:56 PDT
Add pipewire socket to bwrap as bind mount.
Attachments
Patch (2.23 KB, patch)
2020-09-16 03:42 PDT, Víctor M. Jáquez L. 		no flags
DetailsFormatted DiffDiff
Patch (1.35 KB, patch)
2020-09-17 10:05 PDT, Víctor M. Jáquez L. 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Víctor M. Jáquez L.
Comment 1 2020-09-16 03:42:32 PDT
Created attachment 408910 [details] Patch
Víctor M. Jáquez L.
Comment 2 2020-09-16 03:43:40 PDT
pipewire 0.3 is already merged in Debian testing
Philippe Normand
Comment 3 2020-09-16 07:44:39 PDT
Comment on attachment 408910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408910&action=review > Tools/ChangeLog:9 > + pipewire server version is bigger than 0.3 Why is it needed to check the version?
Víctor M. Jáquez L.
Comment 4 2020-09-16 09:08:41 PDT
(In reply to Philippe Normand from comment #3) > Comment on attachment 408910 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408910&action=review > > > Tools/ChangeLog:9 > > + pipewire server version is bigger than 0.3 > > Why is it needed to check the version? I thought it would be cumbersome to add a binding mountpoint to an useless socket (or does the client support back compatibility?). But still, the drawback of it, as far as I'm aware, is it should be upgraded when the pipewire protocol is upgraded.
Philippe Normand
Comment 5 2020-09-16 09:16:58 PDT
Comment on attachment 408910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408910&action=review >>> Tools/ChangeLog:9 >>> + pipewire server version is bigger than 0.3 >> >> Why is it needed to check the version? > > I thought it would be cumbersome to add a binding mountpoint to an useless socket (or does the client support back compatibility?). > > But still, the drawback of it, as far as I'm aware, is it should be upgraded when the pipewire protocol is upgraded. Another option could be to add it in `try_bind_mounts` and let bwrap itself check the existence of the socket.
Víctor M. Jáquez L.
Comment 6 2020-09-17 10:05:06 PDT
Created attachment 409047 [details] Patch
EWS
Comment 7 2020-09-17 11:07:50 PDT
Committed r267200: <https://trac.webkit.org/changeset/267200> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409047 [details].
Radar WebKit Bug Importer
Comment 8 2020-09-17 11:08:16 PDT
<rdar://problem/69082181>
Note You need to log in before you can comment on or make changes to this bug.