Bug 216599

Summary: Non-unified build fixes, early September 2020 edition
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: Tools / TestsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, hi, jer.noble, joepeck, kangil.han, keith_miller, kondapallykalyan, macpherson, mark.lam, menard, mmaxfield, msaboff, pdr, philipj, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216584    
Attachments:
Description Flags
WIP
none
Patch
none
Patch for landing none

Lauro Moura
Reported 2020-09-15 21:59:54 PDT
Let's see if I get this right
Attachments
WIP (22.64 KB, patch)
2020-09-15 22:54 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch (24.62 KB, patch)
2020-09-16 05:07 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.64 KB, patch)
2020-09-16 07:09 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-09-15 22:54:33 PDT
Created attachment 408898 [details] WIP
Lauro Moura
Comment 2 2020-09-15 22:55:26 PDT
Still some bits left after rebasing.
Adrian Perez
Comment 3 2020-09-16 05:07:18 PDT
Created attachment 408914 [details] Patch
Adrian Perez
Comment 4 2020-09-16 05:56:25 PDT
Lauro: I hope you don't mind that I took your patch and finished it, I have credited you in the ChangeLogs O:-)
EWS
Comment 5 2020-09-16 07:01:11 PDT
ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.
Adrian Perez
Comment 6 2020-09-16 07:09:56 PDT
Created attachment 408919 [details] Patch for landing
EWS
Comment 7 2020-09-16 08:09:33 PDT
Committed r267143: <https://trac.webkit.org/changeset/267143> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408919 [details].
Radar WebKit Bug Importer
Comment 8 2020-09-16 08:10:18 PDT
<rdar://problem/68989782>
Note You need to log in before you can comment on or make changes to this bug.