Bug 216582

Summary:

Remove ENABLE_METER_ELEMENT

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

WebCore Misc.

Assignee:

Stephan Szabo <stephan.szabo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, annulen, apinheiro, benjamin, cdumez, cfleizach, changseok, cmarcelo, dmazzoni, don.olmstead, esprehn+autocc, ews-watchlist, fujii.hironori, glenn, gyuyoung.kim, jbedard, jcraig, jdiggs, kondapallykalyan, macpherson, menard, pdr, ross.kirsling, ryuan.choi, samuel_white, sam, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+
WIP flag removal	none
Remove ENABLE_METER_ELEMENT	ews-feeder: commit-queue-
Remove ENABLE_METER_ELEMENT	none

Stephan Szabo

Reported 2020-09-15 14:06:08 PDT

Turn on meter element support for playstation

Attachments
Patch (1.76 KB, patch) 2020-09-15 14:13 PDT, Stephan Szabo	sam: review+	Details Formatted Diff Diff
WIP flag removal (35.81 KB, patch) 2020-09-15 18:59 PDT, Stephan Szabo	no flags	Details Formatted Diff Diff
Remove ENABLE_METER_ELEMENT (39.77 KB, patch) 2020-09-16 13:02 PDT, Stephan Szabo	ews-feeder: commit-queue-	Details Formatted Diff Diff
Remove ENABLE_METER_ELEMENT (40.40 KB, patch) 2020-09-16 13:19 PDT, Stephan Szabo	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Stephan Szabo

Comment 1 2020-09-15 14:13:56 PDT

Created attachment 408862 [details] Patch

Sam Weinig

Comment 2 2020-09-15 16:18:49 PDT

Comment on attachment 408862 [details] Patch Are there any remaining ports with the meter element disabled? If there aren't we should just get rid of ifdef entirely.

Stephan Szabo

Comment 3 2020-09-15 18:59:59 PDT

Created attachment 408884 [details] WIP flag removal

Stephan Szabo

Comment 4 2020-09-16 13:02:53 PDT

Created attachment 408947 [details] Remove ENABLE_METER_ELEMENT

Stephan Szabo

Comment 5 2020-09-16 13:19:45 PDT

Created attachment 408948 [details] Remove ENABLE_METER_ELEMENT

EWS

Comment 6 2020-09-16 15:30:05 PDT

Committed r267166: <https://trac.webkit.org/changeset/267166> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408948 [details].

Radar WebKit Bug Importer

Comment 7 2020-09-16 15:31:19 PDT

<rdar://problem/69018966>

Note You need to log in before you can comment on or make changes to this bug.