Bug 216562

Summary: Remove runtime setting for enabling/disabling the isSecureContext API?
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebCore Misc.Assignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer, webkit-unassigned
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216512    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Sam Weinig 2020-09-15 09:34:12 PDT 
Remove runtime setting for enabling/disabling the isSecureContext API. It should always be enabled at this point.
Comment 1 Sam Weinig 2020-09-16 10:13:05 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-16 10:40:03 PDT 
Created attachment 408934 [details]
Patch
Comment 3 Sam Weinig 2020-09-16 12:26:42 PDT 
Created attachment 408942 [details]
Patch
Comment 4 Darin Adler 2020-09-16 12:33:47 PDT 
Comment on attachment 408942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408942&action=review

r=me assuming tests pass

> Source/WebCore/page/WindowOrWorkerGlobalScope.idl:64
> +    // microtask queuing.

Capitalize microtask if we are using sentence style? Also, why does a single function "queue microtask" need a comment saying "microtask queuing"? I’m not sure of the value of these section comments.
Comment 5 Sam Weinig 2020-09-16 13:13:24 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 408942 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408942&action=review
> 
> r=me assuming tests pass
> 
> > Source/WebCore/page/WindowOrWorkerGlobalScope.idl:64
> > +    // microtask queuing.
> 
> Capitalize microtask if we are using sentence style? Also, why does a single
> function "queue microtask" need a comment saying "microtask queuing"? I’m
> not sure of the value of these section comments.

They come from the spec text. I've mostly been keeping them to make diffing against the spec text easier.
Comment 6 EWS 2020-09-16 15:04:50 PDT 
Committed r267164: <https://trac.webkit.org/changeset/267164>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408942 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-16 15:05:18 PDT 
<rdar://problem/69017378>