Bug 216562

Summary: Remove runtime setting for enabling/disabling the isSecureContext API?
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebCore Misc.Assignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer, webkit-unassigned
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216512    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Sam Weinig
Reported 2020-09-15 09:34:12 PDT
Remove runtime setting for enabling/disabling the isSecureContext API. It should always be enabled at this point.
Attachments
Patch (28.90 KB, patch)
2020-09-16 10:13 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (28.91 KB, patch)
2020-09-16 10:40 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (28.83 KB, patch)
2020-09-16 12:26 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-16 10:13:05 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-09-16 10:40:03 PDT
Created attachment 408934 [details] Patch
Sam Weinig
Comment 3 2020-09-16 12:26:42 PDT
Created attachment 408942 [details] Patch
Darin Adler
Comment 4 2020-09-16 12:33:47 PDT
Comment on attachment 408942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408942&action=review r=me assuming tests pass > Source/WebCore/page/WindowOrWorkerGlobalScope.idl:64 > + // microtask queuing. Capitalize microtask if we are using sentence style? Also, why does a single function "queue microtask" need a comment saying "microtask queuing"? I’m not sure of the value of these section comments.
Sam Weinig
Comment 5 2020-09-16 13:13:24 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 408942 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408942&action=review > > r=me assuming tests pass > > > Source/WebCore/page/WindowOrWorkerGlobalScope.idl:64 > > + // microtask queuing. > > Capitalize microtask if we are using sentence style? Also, why does a single > function "queue microtask" need a comment saying "microtask queuing"? I’m > not sure of the value of these section comments. They come from the spec text. I've mostly been keeping them to make diffing against the spec text easier.
EWS
Comment 6 2020-09-16 15:04:50 PDT
Committed r267164: <https://trac.webkit.org/changeset/267164> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408942 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-16 15:05:18 PDT
<rdar://problem/69017378>
Note You need to log in before you can comment on or make changes to this bug.