Bug 216493 – Move cookie flushing SPI from WKProcessPool to WKHTTPCookieStore

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Move cookie flushing SPI from WKProcessPool to WKHTTPCookieStore

[Alex Christensen]

Created attachment 408737 [details]
Patch

[Alex Christensen]

<rdar://problem/68749055>

[Alex Christensen]

Comment on attachment 408737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408737&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h:30
>  - (void)_setCookieAcceptPolicy:(NSHTTPCookieAcceptPolicy)policy completionHandler:(void (^)())completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

This also needs a void inside the () to be able to be compiled from ObjC (not ObjC++).  I'll add when committing this.

[Alex Christensen]

Comment on attachment 408737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408737&action=review

> Source/WebKit/ChangeLog:11
> +        rdar://problem/68749055 tracks adoption in Safari, which I will land within an hour of landing this to avoid cookie regressions.

rdar://problem/68872711 is the correct radar.  Will fix before landing.

[Chris Dumez]

Comment on attachment 408737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408737&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:228
> +    platformSyncAllCookies(WTFMove(completionHandler));

Since this is now on the HTTPCookieStore (which is associated with a single data store AFAIK), don't we want to sync cookies for the cookie store 's session only instead of doing it for ALL sessions?

[Alex Christensen]

Created attachment 408746 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r267042