Summary: | Add a key to the text manipulation userInfo dictionary indicating whether the translated item is on-screen | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | WebKit2 | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, ews-watchlist, mifenton, sihui_liu, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2020-09-12 19:23:34 PDT
Created attachment 408631 [details]
Patch
Comment on attachment 408631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408631&action=review > Source/WebCore/editing/TextManipulationController.cpp:300 > + if (auto frame = makeRefPtr(node->document().frame()); frame->view() && element->renderer()) { This doesn’t null check the frame. I think you want: ... frame()); frame && frame->view() && ... Comment on attachment 408631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408631&action=review >> Source/WebCore/editing/TextManipulationController.cpp:300 >> + if (auto frame = makeRefPtr(node->document().frame()); frame->view() && element->renderer()) { > > This doesn’t null check the frame. I think you want: > > ... frame()); frame && frame->view() && ... Fixed! Good catch. Created attachment 408647 [details]
Patch for landing
Committed r266993: <https://trac.webkit.org/changeset/266993> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408647 [details]. |