Bug 216452

Summary: Add a key to the text manipulation userInfo dictionary indicating whether the translated item is on-screen
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mifenton, sihui_liu, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch for landing none

Wenson Hsieh
Reported 2020-09-12 19:23:34 PDT
SSIA
Attachments
Patch (12.39 KB, patch)
2020-09-12 19:56 PDT, Wenson Hsieh 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (12.49 KB, patch)
2020-09-13 08:07 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-09-12 19:56:20 PDT
Created attachment 408631 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-09-12 19:56:46 PDT
<rdar://problem/68785397>
Darin Adler
Comment 3 2020-09-12 23:16:35 PDT
Comment on attachment 408631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408631&action=review > Source/WebCore/editing/TextManipulationController.cpp:300 > + if (auto frame = makeRefPtr(node->document().frame()); frame->view() && element->renderer()) { This doesn’t null check the frame. I think you want: ... frame()); frame && frame->view() && ...
Wenson Hsieh
Comment 4 2020-09-13 08:04:04 PDT
Comment on attachment 408631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408631&action=review >> Source/WebCore/editing/TextManipulationController.cpp:300 >> + if (auto frame = makeRefPtr(node->document().frame()); frame->view() && element->renderer()) { > > This doesn’t null check the frame. I think you want: > > ... frame()); frame && frame->view() && ... Fixed! Good catch.
Wenson Hsieh
Comment 5 2020-09-13 08:07:32 PDT
Created attachment 408647 [details] Patch for landing
EWS
Comment 6 2020-09-13 08:44:02 PDT
Committed r266993: <https://trac.webkit.org/changeset/266993> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408647 [details].
Note You need to log in before you can comment on or make changes to this bug.