Bug 216448

Summary:

[Apple Win] Migrate from FontPlatformDataWin.cpp to FontPlatformDataCoreText.cpp

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, dbarton, dino, ews-watchlist, fred.wang, fujii.hironori, jonlee, mmaxfield, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

216353

Attachments:

Description	Flags
WIP	none
WIP	none
Patch	none
WIP	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
WIP	none
Patch	none
Patch	darin: review+

Myles C. Maxfield

Reported 2020-09-12 15:55:02 PDT

This is one of the steps on the way to https://bugs.webkit.org/show_bug.cgi?id=216353 [Apple Win] Migrate the Apple Win port's font code to Core Text from Core Graphics

Attachments
WIP (5.23 KB, patch) 2020-09-12 15:55 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (6.05 KB, patch) 2020-09-12 15:59 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (8.06 KB, patch) 2020-09-12 16:19 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (9.42 KB, patch) 2020-09-12 20:32 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (19.54 KB, patch) 2020-09-12 20:52 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (19.53 KB, patch) 2020-09-12 20:56 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (19.87 KB, patch) 2020-09-12 21:02 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (21.09 KB, patch) 2020-09-12 21:38 PDT, Myles C. Maxfield	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP (25.79 KB, patch) 2020-09-14 01:52 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (27.88 KB, patch) 2020-09-14 01:56 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (28.07 KB, patch) 2020-09-14 13:52 PDT, Myles C. Maxfield	darin: review+	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2020-09-12 15:55:30 PDT

Created attachment 408620 [details] WIP

Myles C. Maxfield

Comment 2 2020-09-12 15:59:09 PDT

Created attachment 408621 [details] WIP

Myles C. Maxfield

Comment 3 2020-09-12 16:19:35 PDT

Created attachment 408623 [details] Patch

Myles C. Maxfield

Comment 4 2020-09-12 16:24:32 PDT

Comment on attachment 408623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408623&action=review > Source/WebCore/ChangeLog:8 > + This is one of the steps toward migrating the Apple Win port off of Core Graphics and on to Not off Core Graphics itself, but off of CGFont.

Myles C. Maxfield

Comment 5 2020-09-12 18:24:01 PDT

Looks like this requires createFontCustomPlatformData() to be migrated first.

Myles C. Maxfield

Comment 6 2020-09-12 20:32:30 PDT

Created attachment 408632 [details] WIP

Myles C. Maxfield

Comment 7 2020-09-12 20:52:25 PDT

Created attachment 408635 [details] Patch

Myles C. Maxfield

Comment 8 2020-09-12 20:56:25 PDT

Created attachment 408636 [details] Patch

Myles C. Maxfield

Comment 9 2020-09-12 21:02:09 PDT

Created attachment 408637 [details] Patch

Myles C. Maxfield

Comment 10 2020-09-12 21:38:52 PDT

Created attachment 408639 [details] Patch

Myles C. Maxfield

Comment 11 2020-09-14 01:52:47 PDT

Created attachment 408690 [details] WIP

Myles C. Maxfield

Comment 12 2020-09-14 01:56:42 PDT

Created attachment 408691 [details] Patch

Myles C. Maxfield

Comment 13 2020-09-14 13:52:47 PDT

Created attachment 408744 [details] Patch

Darin Adler

Comment 14 2020-09-14 17:31:37 PDT

Comment on attachment 408744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408744&action=review > Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp:117 > + auto bufferData = buffer.createCFData(); > + result->fontDescriptor = adoptCF(CTFontManagerCreateFontDescriptorFromData(bufferData.get())); Reads better without a local variable, I think.

Myles C. Maxfield

Comment 15 2020-09-14 21:19:31 PDT

Committed r267073: <https://trac.webkit.org/changeset/267073>

Radar WebKit Bug Importer

Comment 16 2020-09-14 21:20:15 PDT

<rdar://problem/68898486>

Fujii Hironori

Comment 17 2020-09-14 22:57:56 PDT

Committed r267077: <https://trac.webkit.org/changeset/267077>

Note You need to log in before you can comment on or make changes to this bug.