Summary: | [Apple Win] Migrate from FontPlatformDataWin.cpp to FontPlatformDataCoreText.cpp | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||
Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
Severity: | Normal | CC: | darin, dbarton, dino, ews-watchlist, fred.wang, Hironori.Fujii, jonlee, mmaxfield, simon.fraser, thorton, webkit-bug-importer | ||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||||||
Bug Blocks: | 216353 | ||||||||||||||||||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2020-09-12 15:55:02 PDT
Created attachment 408620 [details]
WIP
Created attachment 408621 [details]
WIP
Created attachment 408623 [details]
Patch
Comment on attachment 408623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408623&action=review > Source/WebCore/ChangeLog:8 > + This is one of the steps toward migrating the Apple Win port off of Core Graphics and on to Not off Core Graphics itself, but off of CGFont. Looks like this requires createFontCustomPlatformData() to be migrated first. Created attachment 408632 [details]
WIP
Created attachment 408635 [details]
Patch
Created attachment 408636 [details]
Patch
Created attachment 408637 [details]
Patch
Created attachment 408639 [details]
Patch
Created attachment 408690 [details]
WIP
Created attachment 408691 [details]
Patch
Created attachment 408744 [details]
Patch
Comment on attachment 408744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408744&action=review > Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp:117 > + auto bufferData = buffer.createCFData(); > + result->fontDescriptor = adoptCF(CTFontManagerCreateFontDescriptorFromData(bufferData.get())); Reads better without a local variable, I think. Committed r267073: <https://trac.webkit.org/changeset/267073> Committed r267077: <https://trac.webkit.org/changeset/267077> |