Bug 216446

Summary: [Apple Win] Migrate from CGFontGetGlyphsForUnichars() to CTFontGetGlyphsForCharacters()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, dbarton, ews-watchlist, fred.wang, gyuyoung.kim, mmaxfield, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216353    
Attachments:
Description Flags
WIP
none
Image
none
WIP
none
Patch darin: review+

Myles C. Maxfield
Reported 2020-09-12 15:12:20 PDT
This is one of the steps toward https://bugs.webkit.org/show_bug.cgi?id=216353 [Apple Win] Migrate the Apple Win port's font code to Core Text from Core Graphics
Attachments
WIP (78.67 KB, patch)
2020-09-12 15:12 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Image (36.19 KB, image/png)
2020-09-12 15:20 PDT, Myles C. Maxfield 		no flags
Details
WIP (46.59 KB, patch)
2020-09-12 15:23 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (84.10 KB, patch)
2020-09-12 16:26 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-09-12 15:12:48 PDT
Created attachment 408614 [details] WIP
Myles C. Maxfield
Comment 2 2020-09-12 15:20:13 PDT
Created attachment 408615 [details] Image
Myles C. Maxfield
Comment 3 2020-09-12 15:23:26 PDT
Created attachment 408616 [details] WIP
Myles C. Maxfield
Comment 4 2020-09-12 16:26:03 PDT
Created attachment 408625 [details] Patch
Darin Adler
Comment 5 2020-09-12 23:15:36 PDT
Comment on attachment 408625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408625&action=review > LayoutTests/ChangeLog:10 > + * fast/text/flag-codepoint.html: The Windows emoji font draws slighly higher than the ascent. Typo: "slighly".
Myles C. Maxfield
Comment 6 2020-09-14 01:17:08 PDT
Committed r267008: <https://trac.webkit.org/changeset/267008>
Radar WebKit Bug Importer
Comment 7 2020-09-14 01:18:17 PDT
<rdar://problem/68837050>
Note You need to log in before you can comment on or make changes to this bug.