| Summary: | Small cleanup in DateTimeFieldElements | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||||
| Component: | WebCore Misc. | Assignee: | Aditya Keerthi <akeerthi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, changseok, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, rniwa, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aditya Keerthi
2020-09-09 19:40:10 PDT
Created attachment 408404 [details]
Patch
Comment on attachment 408404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408404&action=review > Source/WebCore/ChangeLog:12 > + Removed virtual from overridden methods and reordered declarations for consistency. You should add override or final to overridden virtual functions, not just remove virtual. What Darin said. The classes are all final, is final still required? Following the comment here: https://bugs.webkit.org/show_bug.cgi?id=215155#c20. (In reply to Aditya Keerthi from comment #4) > The classes are all final, is final still required? > > Following the comment here: > https://bugs.webkit.org/show_bug.cgi?id=215155#c20. Yes. https://webkit.org/code-style-guidelines/#override-methods Created attachment 408410 [details]
Patch
Committed r266824: <https://trac.webkit.org/changeset/266824> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408410 [details]. |