Bug 216339

Summary: Small cleanup in DateTimeFieldElements
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: WebCore Misc.Assignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, rniwa, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Aditya Keerthi
Reported 2020-09-09 19:40:10 PDT
Address some post-review comments after r266779.
Attachments
Patch (3.27 KB, patch)
2020-09-09 19:42 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (5.14 KB, patch)
2020-09-09 21:12 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-09-09 19:42:44 PDT
Created attachment 408404 [details] Patch
Darin Adler
Comment 2 2020-09-09 20:15:07 PDT
Comment on attachment 408404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408404&action=review > Source/WebCore/ChangeLog:12 > + Removed virtual from overridden methods and reordered declarations for consistency. You should add override or final to overridden virtual functions, not just remove virtual.
Ryosuke Niwa
Comment 3 2020-09-09 20:21:53 PDT
What Darin said.
Aditya Keerthi
Comment 4 2020-09-09 20:46:59 PDT
The classes are all final, is final still required? Following the comment here: https://bugs.webkit.org/show_bug.cgi?id=215155#c20.
Ryosuke Niwa
Comment 5 2020-09-09 21:02:31 PDT
(In reply to Aditya Keerthi from comment #4) > The classes are all final, is final still required? > > Following the comment here: > https://bugs.webkit.org/show_bug.cgi?id=215155#c20. Yes. https://webkit.org/code-style-guidelines/#override-methods
Aditya Keerthi
Comment 6 2020-09-09 21:12:01 PDT
Created attachment 408410 [details] Patch
EWS
Comment 7 2020-09-10 07:39:17 PDT
Committed r266824: <https://trac.webkit.org/changeset/266824> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408410 [details].
Radar WebKit Bug Importer
Comment 8 2020-09-10 07:40:18 PDT
<rdar://problem/68642387>
Note You need to log in before you can comment on or make changes to this bug.