Summary: | [webkitscmpy] Add tags, branches queries on local repositories | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dewei_zhu, jlewis3, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=215862 | ||||||||
Attachments: |
|
Description
Jonathan Bedard
2020-09-09 16:20:08 PDT
Created attachment 408384 [details]
Patch
Comment on attachment 408384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408384&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:60 > + with mocks.local.Git(self.path, branches=('branch-1', 'branch-2')): > + self.assertEqual( > + local.Git(self.path).branches, > + ['main', 'branch-1', 'branch-2'], > + ) Maybe add `remotes/origin/HEAD -> origin/main`to the test case and expect it to be excluded? Comment on attachment 408384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408384&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:60 >> + ) > > Maybe add `remotes/origin/HEAD -> origin/main`to the test case and expect it to be excluded? Maybe also include `* current-bench` to expect it to be 'current-branch' in the output. Created attachment 408413 [details]
Patch
Committed r266826: <https://trac.webkit.org/changeset/266826> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408413 [details]. |