Bug 216316

Summary: [WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, annulen, cdumez, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2020-09-09 10:13:47 PDT
[WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
Attachments
Patch (16.62 KB, patch)
2020-09-09 10:15 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (23.32 KB, patch)
2020-09-09 13:58 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-09 10:15:05 PDT
Created attachment 408333 [details] Patch
Darin Adler
Comment 2 2020-09-09 10:31:20 PDT
Comment on attachment 408333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408333&action=review > Source/WebCore/dom/GlobalEventHandlers.idl:96 > Remove one more blank line?
Sam Weinig
Comment 3 2020-09-09 11:01:49 PDT
Going to have to fix those test results too.
Darin Adler
Comment 4 2020-09-09 11:04:27 PDT
"dom-static-property-for-in-iteration.html" Is there a specification of what order these properties should be iterated?
Sam Weinig
Comment 5 2020-09-09 13:46:05 PDT
(In reply to Darin Adler from comment #4) > "dom-static-property-for-in-iteration.html" > > Is there a specification of what order these properties should be iterated? It's still an open issue when it comes to mixins and partials - https://github.com/heycam/webidl/issues/432.
Sam Weinig
Comment 6 2020-09-09 13:58:40 PDT
Created attachment 408365 [details] Patch
EWS
Comment 7 2020-09-09 15:13:58 PDT
Committed r266801: <https://trac.webkit.org/changeset/266801> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408365 [details].
Radar WebKit Bug Importer
Comment 8 2020-09-09 15:14:16 PDT
<rdar://problem/68598951>
Note You need to log in before you can comment on or make changes to this bug.