Bug 216301 – Import selection web platform tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Import selection web platform tests

[Alex Christensen]

Created attachment 408300 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Alexey Proskuryakov]

Comment on attachment 408300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408300&action=review

> LayoutTests/ChangeLog:3


Why?

[Alexey Proskuryakov]

I know what the cost is - slower tests and thus lower engineering efficiency. What is the benefit?

[Alex Christensen]

My thought was that this could be a good first step in fixing the failures.  Alternatively, I could just keep this on a local branch and make the fixes that fix these failures with a smaller number of tests I write myself.

Would skipping these tests in debug builds or in wk1 make you less hesitant to add these?

[youenn fablet]

Comment on attachment 408300 [details]
Patch

Skipping timing out tests is always preferable than running them.
It is also better to import all tests in a folder: we can fix them progressively and we do not have to spend the time to rediscover they are timing out on each reimport.

Looking at some of these tests, they end up with more than 5000 subtests...
Alex, please verify these tests pass in debug.

[Alex Christensen]

Added iOS expectations for selection-select-all-move-input-crash.html too.
http://trac.webkit.org/r266784

[Radar WebKit Bug Importer]

<rdar://problem/68576888>

[Alex Christensen]

http://trac.webkit.org/r266785

[Alexey Proskuryakov]

(In reply to Alex Christensen from comment #5)
> My thought was that this could be a good first step in fixing the failures. 

Makes sense, and we've been taking this approach a lot. I don't think that we have a great way to make these decisions, but "more tests is better" feels wrong to me at this point.

> Alternatively, I could just keep this on a local branch and make the fixes
> that fix these failures with a smaller number of tests I write myself.
> 
> Would skipping these tests in debug builds or in wk1 make you less hesitant
> to add these?

Since this is all in WebCore, skipping in WK1 seems like a good idea. But I don't want to slow down WK2 tests either, and certainly we want to catch debug assertions too.